summaryrefslogtreecommitdiffstatshomepage
Commit message (Collapse)AuthorAge
* Docs: Correct property type for `WP_Tax_Query::$no_results`.HEADtrunkSergey Biryukov29 hours
| | | | | | | | | Follow-up to [17686]. Props justlevine, johnbillion. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60311 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove extra check in ↵Sergey Biryukov3 days
| | | | | | | | | | | | | `wp_authenticate_application_password()`. This commit removes an unnecessary `is_wp_error()` check, as the `WP_Error` instance is created earlier in the method, and the only mutability is whether the instance actually `::has_errors()`. Follow-up to [49109]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60310 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove extra `empty()` in `request_filesystem_credentials()`.Sergey Biryukov4 days
| | | | | | | | | | | This commit removes an unnecessary `empty( $connection_type )` check, as the left side of the same conditional already accounts for a possibly empty value. Follow-up to [37467]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60309 602fd350-edb4-49c9-b593-d223f7449a82
* Build/Test Tools: Improve dev environment's CLI in speed, non-interactive ↵Weston Ruter4 days
| | | | | | | | | | | | | | | | | usage, and argument handling. * Start `cli` container when running `env:start`. This greatly speeds up calls to WP-CLI since the container is already running rather than having to start up for each call. * Facilitate calls to `env:cli` in non-interactive context (non-TTY) to allow piping content into commands or use in shell scripts. * Fix passing arguments to WP-CLI from `env:cli` so that arguments with spaces are passed as expected. * Fix JSHint issues. This aligns the wordpress-develop environment closer to wp-env. See https://github.com/WordPress/gutenberg/pull/50007. Props westonruter, jorbin, SirLouen, sandeepdahiya. Fixes #63564. git-svn-id: https://develop.svn.wordpress.org/trunk@60308 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct parameter type for the `oembed_dataparse` filter.Sergey Biryukov4 days
| | | | | | | | | | | | | | | | This commit updates the filter documentation to indicate that it can both take and return a `string|false` value. Documentation for functions attached to the filter has been similarly corrected: * `WP_oEmbed::_strip_newlines()` * `wp_filter_oembed_result()` * `wp_filter_oembed_iframe_title_attribute()` Follow-up to [12153], [25723], [34903], [34974], [44942]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60307 602fd350-edb4-49c9-b593-d223f7449a82
* Login and Registration: Ensure a revealed password is reverted to the ↵John Blackbourn4 days
| | | | | | | | | | | | `password` input type upon form submission. This means if a password has been toggled to visible by the user, or is visible by default, it gets reverted to the `password` type to prevent browsers from remembering it as a previously-provided value and potentially displaying it as an autofill option on non-password inputs. Props jamieburchell, sukhendu2002, vgnavada Fixes #62147 git-svn-id: https://develop.svn.wordpress.org/trunk@60306 602fd350-edb4-49c9-b593-d223f7449a82
* Build/Test Tools: Improve `env:install` command with better configurability ↵Weston Ruter5 days
| | | | | | | | | | | | | | | | | | and error handling. * Force WP-CLI to use the `wp-config.php` in the directory above the `src` directory via the `WP_CONFIG_PATH` environment variable [read by WP-CLI](https://github.com/wp-cli/wp-cli/blob/2800ad0a66747a826ae4221b2f022f1df6779cb6/php/utils.php#L328-L329) in the `wp_locate_config()` function. * Update the `env:install` command to write out the config at the repo root instead of writing it inside of the `ABSPATH` only then to move it one directory up. * Fix JSHint issues. * Add error handling to when `npm run env:install` is executed without having first done `npm run env:start`, in which case the script will end with an exit code of 1 and emit: > Error: It appears the development environment has not been started. Message: Timed out waiting for: tcp:localhost:8000 > Did you forget to do 'npm run env:start'? Fixes #63543. Props westonruter, jorbin, SirLouen. git-svn-id: https://develop.svn.wordpress.org/trunk@60305 602fd350-edb4-49c9-b593-d223f7449a82
* Comments: Remove `novalidate` attribute from comments form by default.Weston Ruter5 days
| | | | | | | | | | | | | | | | | | | Browser support for client-side validation is now reliable. Blocking the form submission when there is a missing/invalid field prevents the possibility of losing comment content when bfcache does not restore the previous page when going back. To retain the `novalidate` attribute, the `comment_form()`'s args now accepts a `novalidate` key which will add the attribute when it is `true`. This can also be supplied by the `comment_form_default_fields` filter, for example: {{{#!php add_filter( 'comment_form_defaults', function ( $args ) { $args['novalidate'] = true; return $args; } ); }}} Fixes #47595. Props westonruter, joedolson, sabernhardt, afercia, SergeyBiryukov, guddu1315, pfefferle, oglekler, bugnumber9. git-svn-id: https://develop.svn.wordpress.org/trunk@60304 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Add missing `@deprecated` tag for `::set_imagick_time_limit()`.Sergey Biryukov5 days
| | | | | | | | | Follow-up to [56250]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60303 602fd350-edb4-49c9-b593-d223f7449a82
* Twenty Nineteen: Make mobile nav menu scrollable.Jb Audras5 days
| | | | | | | | | | | This changeset fixes an issue where Twenty Nineteen's primary nav menu panel wasn’t scrollable when the primary menu contains a lot of items, preventing to scroll down to see all menu items. Props kjellr, karmatosed, lakshyajeet, coralietixeront, Spaceshipone, maxpertici, beryldlg. Fixes #45902. git-svn-id: https://develop.svn.wordpress.org/trunk@60302 602fd350-edb4-49c9-b593-d223f7449a82
* REST API: Return a more appropriate HTTP 400 response code when attempting ↵John Blackbourn6 days
| | | | | | | | | | | | to create or update a non-existent setting. This switches the response from a 200, which is not appropriate for invalid requests. Props sheldorofazeroth, johnbillion Fixes #41604 git-svn-id: https://develop.svn.wordpress.org/trunk@60301 602fd350-edb4-49c9-b593-d223f7449a82
* Media: Fix the documented return type of the ↵John Blackbourn6 days
| | | | | | | | | | `wp_update_attachment_metadata()` function. Props justlevine See #63268 git-svn-id: https://develop.svn.wordpress.org/trunk@60300 602fd350-edb4-49c9-b593-d223f7449a82
* Users: Correct `get_the_author_posts()` to always return an integer.Sergey Biryukov6 days
| | | | | | | | | | | This matches the documented `@return` type. Follow-up to [5638], [13576], [36085], [60296]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60299 602fd350-edb4-49c9-b593-d223f7449a82
* Build/Test Tools: Reduce the bcrypt cost during testing in order to speed up ↵John Blackbourn6 days
| | | | | | | | | | tests. The lowest allowable cost in PHP is 4, so 5 is used which means tests can still to reduce the cost by one when testing alterations to the cost. See #63026 git-svn-id: https://develop.svn.wordpress.org/trunk@60298 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct the documented types of the password algorithm constants in ↵John Blackbourn6 days
| | | | | | | | PHP 7.3 and earlier. See #63166 git-svn-id: https://develop.svn.wordpress.org/trunk@60297 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct the type of the `$count` parameter in `get_usernumposts` filter.Sergey Biryukov7 days
| | | | | | | | | Follow-up to [8873], [26901], [36085]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60296 602fd350-edb4-49c9-b593-d223f7449a82
* Tests: Add new `assertEqualHTML` assertion.bernhard-reiter7 days
| | | | | | | | | | | | | Add a new `assertEqualHTML` method to `WP_UnitTestClass` for tests comparing HTML (potentially including block markup). Internally, the assertion builds a deterministic tree string representation of the markup (using the HTML API) and compares the results. The format of the tree is inspired by the HTML5lib-tests tree format. It is extended with a special representation of block delimiters and their attributes. This format also makes it easier to visually spot the differences between the two strings if the assertion fails. Finally, this changeset updates `Tests_Dependencies_Scripts` to remove its `assertEqualMarkup` and `parse_markup_fragment` methods, and to use the newly introduced `assertEqualHTML` instead. Props bernhard-reiter, jonsurrell, dmsnell, jorbin, gziolo. Fixes #63527. git-svn-id: https://develop.svn.wordpress.org/trunk@60295 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove redundant `empty()` checks in `map_meta_cap()`.Sergey Biryukov8 days
| | | | | | | | | | | There is already a check for `empty( $object_subtype )` that exits the current `case` branch a few lines earlier. Follow-up to [39179], [43378]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60294 602fd350-edb4-49c9-b593-d223f7449a82
* Posts, Post Types: Add `pre_post_insert` action hook before inserting a new ↵Jb Audras9 days
| | | | | | | | | | | | | post. This changeset adds a `pre_post_insert` action hook before inserting a new post via `wp_insert_post()`, allowing developers to modify or inspect post data before insertion. It brings consistency with the `pre_post_update` action hook triggered when a post is updated. Props Hrohh, peterwilsoncc, audrasjb. Fixes #63115. git-svn-id: https://develop.svn.wordpress.org/trunk@60293 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct the type for `WP_List_Table::$_column_headers`.Sergey Biryukov9 days
| | | | | | | | | | | The value is `null` until `::get_column_info()` is called. Follow-up to [31127], [35021]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60292 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove extra check in `WP_Comment_Query::get_comment_ids()`.Sergey Biryukov10 days
| | | | | | | | | | | The preceding `foreach` loop ensures that `$status_clauses` is a non-empty array. Follow-up to [30084]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60291 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove redundant check in `WP_Customize_Widgets`.Sergey Biryukov12 days
| | | | | | | | | | `isset()` is enough to check for the property existence here. Follow-up to [60279]. See #63168. git-svn-id: https://develop.svn.wordpress.org/trunk@60290 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Clarify description for `::create_upload_object` in the attachment ↵Sergey Biryukov12 days
| | | | | | | | | | test factory. Follow-up to [34855], [44497]. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60289 602fd350-edb4-49c9-b593-d223f7449a82
* Users: Prevent creating of empty usernames after sanitization.Peter Wilson12 days
| | | | | | | | | | | Introduces a check in `wp_insert_user()` to ensure the username doesn't have a length of zero after sanitization removes invalid characters. Props kalpeshh, missveronicatv, rayhatron, rinkalpagdar, sergeybiryukov, thehercules. Fixes #57635. git-svn-id: https://develop.svn.wordpress.org/trunk@60288 602fd350-edb4-49c9-b593-d223f7449a82
* Build/Test Tools: Remove unused import.Aaron Jorbin12 days
| | | | | | | | | | In [59279], this import was added but never used, likely since it was also imported as `local_env_uitls` on the next line. Props yogeshbhutkar, mukesh27. Fixes #63477. See #61218. git-svn-id: https://develop.svn.wordpress.org/trunk@60287 602fd350-edb4-49c9-b593-d223f7449a82
* Administration: Hide skip to toolbar link on small viewports.Joe Dolson12 days
| | | | | | | | | Since r55326, the admin sidebar autocloses on small viewports when focus exits the sidebar. Because of this, there is no case where the Skip to Toolbar link will have any function on small viewports. Props sabernhardt, abcd95, alh0319, mleray, joedolson. Fixes #63286. git-svn-id: https://develop.svn.wordpress.org/trunk@60286 602fd350-edb4-49c9-b593-d223f7449a82
* Media: Remove inline scripts targeting `IE < 9`.Jonathan Desrosiers12 days
| | | | | | | | | | | | | In #24902, an inline script was introduced to `wp_playlist_scripts()`, `wp_audio_shortcode()`, and `wp_video_shortcode()` for HTML5 compatibility in browsers running IE 8 and earlier. These browsers have long been unsupported by WordPress, and unsupported by Microsoft for 9 years or more. So this compatibility code is no longer necessary and can safely be removed. Hit the road, Jack, and don't ya come back no more, no more, no more, no more! Props aslamdoctor, mindctrl, nigelnelles, joedolson. Fixes #63471. git-svn-id: https://develop.svn.wordpress.org/trunk@60285 602fd350-edb4-49c9-b593-d223f7449a82
* Users: Update label from "Admin Color Scheme" to "Administration Color Scheme". Jb Audras12 days
| | | | | | | | | | | This prevents confusion between "Admin" as a user role and "Admin" when speaking about the dashboard itself. Props ckoerner, audrasjb, debarghyabanerjee, SergeyBiryukov, corazondejaguar, pedrofigueroa1989. Fixes #63048. git-svn-id: https://develop.svn.wordpress.org/trunk@60284 602fd350-edb4-49c9-b593-d223f7449a82
* Users: A11y: Use autocomplete attributes for user name and email.Joe Dolson12 days
| | | | | | | | | Support autocomplete attributes on user's own profile to improve accessibility. Helps user profile management meet accessibility criteria regarding user input purpose and aids users with mobility impairments. Props greatislander, umeshsinghin, jorbin, lukasfritzedev, joedolson. Fixes #63286. git-svn-id: https://develop.svn.wordpress.org/trunk@60283 602fd350-edb4-49c9-b593-d223f7449a82
* Coding Standards: Remove redundant `! empty()` check in `is_object_in_term()`.Sergey Biryukov12 days
| | | | | | | | | | | If `$object_terms` is empty, the immediately preceding code block causes the function to return early. Follow-up to [8131], [10159]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60282 602fd350-edb4-49c9-b593-d223f7449a82
* Media: remove swfupload flash fallback for media uploads.Adam Silverstein12 days
| | | | | | | | | | | | Remove swfobject and swfupload. These scripts are no longer supported and Flash is dead. Props sainathpoojary, audrasjb, mkeck, tabrisrp. Fixes #52699. git-svn-id: https://develop.svn.wordpress.org/trunk@60281 602fd350-edb4-49c9-b593-d223f7449a82
* Themes: A11y: Fix scroll jump when closing modal navigation.Joe Dolson13 days
| | | | | | | | | Fix an issue where navigation and search modals triggered an undesirable scroll behavior if triggered while the page was not scrolled all the way to the top. Props kjellr, nikunj8866, sabernhardt, karmatosed, sainathpoojary, joedolson. Fixes #52116. git-svn-id: https://develop.svn.wordpress.org/trunk@60280 602fd350-edb4-49c9-b593-d223f7449a82
* Customize: Prevent errors occuring with Classic Theme without Widgets.Jb Audras13 days
| | | | | | | | | | | This changeset prevents the customizer from displaying a warning when a classic theme has no widget area. Props ArtZ91, SirLouen, audrasjb, dilipbheda. Fixes #63151. git-svn-id: https://develop.svn.wordpress.org/trunk@60279 602fd350-edb4-49c9-b593-d223f7449a82
* Site Health: add image output mapping details to the info tab.Adam Silverstein13 days
| | | | | | | | | | | | Add details to the info tab under media handling to show the mapping from uploaded image types to output types. Props ironprogrammer, yogeshbhutkar. Fixes #63047. git-svn-id: https://develop.svn.wordpress.org/trunk@60278 602fd350-edb4-49c9-b593-d223f7449a82
* Build/Test Tools: Test against the latest innovation releases.Jonathan Desrosiers13 days
| | | | | | | | | | | The latest MySQL innovation release is now `9.3`, and the latest MariaDB innovation release (also known as a “rolling release”) is `11.7`. This updates the test matrices and the `.version-support-mysql.json` accordingly. Props peterwilsoncc. See #63167. git-svn-id: https://develop.svn.wordpress.org/trunk@60277 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct alignment for some translator comments.Sergey Biryukov13 days
| | | | | | | | Follow-up to [49154]. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60276 602fd350-edb4-49c9-b593-d223f7449a82
* General: Various fixes to the correctness of code and documentation reported ↵John Blackbourn2025-06-03
| | | | | | | | | | by PHPStan. Props justlevine See #63268 git-svn-id: https://develop.svn.wordpress.org/trunk@60275 602fd350-edb4-49c9-b593-d223f7449a82
* Site Health: Explicitly deprecate `WP_Debug_Data::get_sizes()`, unused since ↵Sergey Biryukov2025-06-03
| | | | | | | | | | | WP 5.6. Follow-up to [49154], [60272]. Props yashjawale, dhruvang21, ankitkumarshah, SergeyBiryukov. Fixes #63516. git-svn-id: https://develop.svn.wordpress.org/trunk@60274 602fd350-edb4-49c9-b593-d223f7449a82
* General: Adjust `WP_Community_Events::format_event_data_time()` deprecation.Sergey Biryukov2025-06-02
| | | | | | | | | | | | | `_deprecated_function()` does not support a custom message, which appears to be redundant here, as the method's DocBlock already indicates that it is unused as of WordPress 5.5.2. Includes correcting the version in the `@deprecated` tag. Follow-up to [49146], [49201]. Props dhruvik18, dhruvang21, rollybueno, SirLouen, SergeyBiryukov. Fixes #63511. git-svn-id: https://develop.svn.wordpress.org/trunk@60273 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Mark `WP_Debug_Data::get_sizes()` as deprecated in WordPress 5.6.Sergey Biryukov2025-06-01
| | | | | | | | Follow-up to [49154]. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60272 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Improve inline docs params for various category template tags functions.Jb Audras2025-06-01
| | | | | | | | | | Props dilipbheda, audrasjb, mukesh27. Fixes #63225. See #63166. git-svn-id: https://develop.svn.wordpress.org/trunk@60271 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Correct the order of parameters in some cache functions used by unit ↵Sergey Biryukov2025-05-31
| | | | | | | | | | | tests. Follow-up to [40561]. Props truptikanzariya, rutvikbhambhi2004, nareshbheda, sabernhardt, mukesh27. Fixes #63497. git-svn-id: https://develop.svn.wordpress.org/trunk@60270 602fd350-edb4-49c9-b593-d223f7449a82
* Users: Add support for Initials and Color Gravatar images in default user ↵Jb Audras2025-05-30
| | | | | | | | | | | | | | profile pics. Gravatar includes support for Initials and Color auto-generated images. This changeset adds them to the built-in feature for user profile images. Props haozi, audrasjb, getsyash, valentingrenier. Fixes #63087. See #57493. git-svn-id: https://develop.svn.wordpress.org/trunk@60269 602fd350-edb4-49c9-b593-d223f7449a82
* Upgrade/Install: Avoid setting focus on password during install.Joe Dolson2025-05-30
| | | | | | | | | | | On the installation screen, focus was set first to the site title field, then moved to the password field. Autofocus should only ever be moved to the first field of a form, so that screen reader users don't miss important fields. Fix by checking whether the site title field is present before setting password field focus. Props zodiac1978, himanshupathak95, abcd95, joedolson. Fixes #63281. git-svn-id: https://develop.svn.wordpress.org/trunk@60268 602fd350-edb4-49c9-b593-d223f7449a82
* Administration: Improve comment actions alignment in the Activity Widget.Jb Audras2025-05-30
| | | | | | | | | | | This changeset improves comment actions alignement on small screens for the Dashboard Activity Widget. Props sainathpoojary, valentingrenier, cedche99, quentinr64600. Fixes #63277. git-svn-id: https://develop.svn.wordpress.org/trunk@60267 602fd350-edb4-49c9-b593-d223f7449a82
* Media: Fix overflow of long user display names on Edit Media screen.Jb Audras2025-05-30
| | | | | | | | | | | | | This changeset resolves an issue where long usernames in the media uploader modal would overflow their container. By adding the dedicated `word-wrap-break-word` class, usernames now properly break into multiple lines. Follow-up to [59834], [59835]. Props sainathpoojary, audrasjb, sabernhardt, renishsurani, SirLouen, valentingrenier. Fixes #63243. git-svn-id: https://develop.svn.wordpress.org/trunk@60266 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Document the `$wp_version` global in `update_core()`.Sergey Biryukov2025-05-30
| | | | | | | | | Follow-up to [17576], [22226], [31124], [32643], [39687]. Props upadalavipul, mukesh27, johnbillion, SergeyBiryukov. Fixes #63496. git-svn-id: https://develop.svn.wordpress.org/trunk@60265 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Improvements and corrections to documentation relating to metadata.John Blackbourn2025-05-29
| | | | | | See #63166 git-svn-id: https://develop.svn.wordpress.org/trunk@60264 602fd350-edb4-49c9-b593-d223f7449a82
* Media: Screen reader improvements for upload media errors.Joe Dolson2025-05-29
| | | | | | | | | Add a screen reader announcement when a media upload fails. Also add an announcement when dismissing upload errors, and improve the labeling context of the dismiss error button to explicitly identify which error will be dismissed. Props joedolson, navi161, yogeshbhutkar, rishavdutta. Fixes #63114. git-svn-id: https://develop.svn.wordpress.org/trunk@60263 602fd350-edb4-49c9-b593-d223f7449a82
* Docs: Document the `$wp_theme_directories` global in `wp_is_block_theme()`.Sergey Biryukov2025-05-29
| | | | | | | | | Follow-up to [52069], [52330]. Props upadalavipul. See #63496. git-svn-id: https://develop.svn.wordpress.org/trunk@60262 602fd350-edb4-49c9-b593-d223f7449a82
generated by cgit v1.2.3 (git 2.39.1) at 2025-06-17 22:01:36 +0000