diff options
author | Sergey Biryukov <sergeybiryukov@git.wordpress.org> | 2021-08-07 10:29:41 +0000 |
---|---|---|
committer | Sergey Biryukov <sergeybiryukov@git.wordpress.org> | 2021-08-07 10:29:41 +0000 |
commit | ddb409edca5132d7aa73c2e45f166a5a915e2dbe (patch) | |
tree | 4b170a5bb4543b513fed90148d751e66c5acd408 /tests/phpunit/includes/testcase-canonical.php | |
parent | cb6bf0263825f5f53b999a8a47786bbd79df29b2 (diff) | |
download | wordpress-ddb409edca5132d7aa73c2e45f166a5a915e2dbe.tar.gz wordpress-ddb409edca5132d7aa73c2e45f166a5a915e2dbe.zip |
Build/Test Tools: Implement use of the `void` solution.
> PHPUnit 8.0.0 introduced a `void` return type declaration to the "fixture" methods – `setUpBeforeClass()`, `setUp()`, `tearDown()` and `tearDownAfterClass()`. As the `void` return type was not introduced until PHP 7.1, this makes it more difficult to create cross-version compatible tests when using fixtures, due to signature mismatches.
>
> The `Yoast\PHPUnitPolyfills\TestCases\TestCase` overcomes the signature mismatch by having two versions. The correct one will be loaded depending on the PHPUnit version being used.
>
> When using this TestCase, if an individual test, or another TestCase which extends this TestCase, needs to overload any of the "fixture" methods, it should do so by using a snake_case variant of the original fixture method name, i.e. `set_up_before_class()`, `set_up()`, `assert_pre_conditions()`, `assert_post_conditions()`, `tear_down()`, and `tear_down_after_class()`.
>
> The snake_case methods will automatically be called by PHPUnit.
>
> > IMPORTANT: The snake_case methods should not call the PHPUnit parent, i.e. do not use `parent::setUp()` from within an overloaded `set_up()` method. If necessary, DO call `parent::set_up()`.
Reference: https://github.com/Yoast/PHPUnit-Polyfills#testcases
This commit renames all declared fixture methods, and calls to parent versions of those fixture methods, from camelCase to snake_case.
Follow-up to [51559-51567].
Props jrf, hellofromTonya, johnbillion, netweb, dd32, pputzer, SergeyBiryukov.
See #46149.
git-svn-id: https://develop.svn.wordpress.org/trunk@51568 602fd350-edb4-49c9-b593-d223f7449a82
Diffstat (limited to 'tests/phpunit/includes/testcase-canonical.php')
-rw-r--r-- | tests/phpunit/includes/testcase-canonical.php | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/phpunit/includes/testcase-canonical.php b/tests/phpunit/includes/testcase-canonical.php index 9c27471a0c..ef33ca8db8 100644 --- a/tests/phpunit/includes/testcase-canonical.php +++ b/tests/phpunit/includes/testcase-canonical.php @@ -23,8 +23,8 @@ class WP_Canonical_UnitTestCase extends WP_UnitTestCase { self::delete_shared_fixtures(); } - public function setUp() { - parent::setUp(); + public function set_up() { + parent::set_up(); update_option( 'page_comments', true ); update_option( 'comments_per_page', 5 ); |