diff options
| author | Alessandro Gatti <a.gatti@frob.it> | 2024-12-20 22:43:14 +0100 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2024-12-23 12:55:20 +1100 |
| commit | 4729a895046908414b239f02256ac3334d1b2c15 (patch) | |
| tree | cb72b40dc8b0e92c50a7718fd1e4f5a2f5fb8e38 /tools | |
| parent | 7ca6e5eb6815de6f7c2792969b0f66cf306f5b91 (diff) | |
| download | micropython-4729a895046908414b239f02256ac3334d1b2c15.tar.gz micropython-4729a895046908414b239f02256ac3334d1b2c15.zip | |
tools/verifygitlog.py: Show invalid commit subjects in quotes.
If a commit subject line has any trailing whitespace it won't match the
repository validation rules, and the line will show up as part of the
relevant error message. However, since there's no quotation marks
around the offending text, the trailing whitespace may go unnoticed, and
given that the commit message is then discarded when the commit
operation is retried this can get fairly annoying.
This commit simply modifies the error output for invalid subject lines
to add quotation marks around the offending text, so trailing whitespace
is much easier to see.
Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/verifygitlog.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/verifygitlog.py b/tools/verifygitlog.py index ad9385e7ac..67215d5c5d 100755 --- a/tools/verifygitlog.py +++ b/tools/verifygitlog.py @@ -47,7 +47,7 @@ def git_log(pretty_format, *args): def diagnose_subject_line(subject_line, subject_line_format, err): - err.error("Subject line: " + subject_line) + err.error('Subject line: "' + subject_line + '"') if not subject_line.endswith("."): err.error('* must end with "."') if not re.match(r"^[^!]+: ", subject_line): |