Remove mp_obj_type_t.methods entry and use .locals_dict instead.

Originally, .methods was used for methods in a ROM class, and
locals_dict for methods in a user-created class.  That distinction is
unnecessary, and we can use locals_dict for ROM classes now that we have
ROMable maps.

This removes an entry in the bloated mp_obj_type_t struct, saving a word
for each ROM object and each RAM object.  ROM objects that have a
methods table (now a locals_dict) need an extra word in total (removed
the methods pointer (1 word), no longer need the sentinel (2 words), but
now need an mp_obj_dict_t wrapper (4 words)).  But RAM objects save a
word because they never used the methods entry.

Overall the ROM usage is down by a few hundred bytes, and RAM usage is
down 1 word per user-defined type/class.

There is less code (no need to check 2 tables), and now consistent with
the way ROM modules have their tables initialised.

Efficiency is very close to equivaluent.

1 files changed, 6 insertions, 4 deletions

diff --git a/stm/servo.c b/stm/servo.c
index cd6370b126..176081e1ad 100644
--- a/stm/servo.c
+++ b/stm/servo.c
@@ -8,6 +8,7 @@
 #include "mpconfig.h"
 #include "qstr.h"
 #include "obj.h"
+#include "map.h"
 #include "servo.h"
 
 // PWM
@@ -146,16 +147,17 @@ STATIC mp_obj_t servo_obj_angle(mp_obj_t self_in, mp_obj_t angle) {
 
 STATIC MP_DEFINE_CONST_FUN_OBJ_2(servo_obj_angle_obj, servo_obj_angle);
 
-STATIC const mp_method_t servo_methods[] = {
-    { MP_QSTR_angle, &servo_obj_angle_obj },
-    { MP_QSTR_NULL, NULL },
+STATIC const mp_map_elem_t servo_locals_dict_table[] = {
+    { MP_OBJ_NEW_QSTR(MP_QSTR_angle), (mp_obj_t)&servo_obj_angle_obj },
 };
 
+STATIC MP_DEFINE_CONST_DICT(servo_locals_dict, servo_locals_dict_table);
+
 STATIC const mp_obj_type_t servo_obj_type = {
     { &mp_type_type },
     .name = MP_QSTR_Servo,
     .print = servo_obj_print,
-    .methods = servo_methods,
+    .locals_dict = (mp_obj_t)&servo_locals_dict,
 };
 
 STATIC mp_obj_t pyb_Servo(mp_obj_t servo_id) {