summaryrefslogtreecommitdiffstatshomepage
path: root/py
diff options
context:
space:
mode:
authorDamien George <damien.p.george@gmail.com>2020-02-11 13:17:41 +1100
committerDamien George <damien.p.george@gmail.com>2020-02-13 11:03:37 +1100
commit97eca38c4f03e76bd464fb25974544a043af2a9e (patch)
tree9141a63cb6e1e414330d0a93e11ceedc955f4c27 /py
parent7679e3be96f7e0996faa89678beaf423d7c25999 (diff)
downloadmicropython-97eca38c4f03e76bd464fb25974544a043af2a9e.tar.gz
micropython-97eca38c4f03e76bd464fb25974544a043af2a9e.zip
py: Add mp_raise_type helper macro and use it where appropriate.
This provides a more consistent C-level API to raise exceptions, ie moving away from nlr_raise towards mp_raise_XXX. It also reduces code size by a small amount on some ports.
Diffstat (limited to 'py')
-rw-r--r--py/modbuiltins.c8
-rw-r--r--py/modthread.c2
-rw-r--r--py/objgenerator.c4
-rw-r--r--py/runtime.h1
4 files changed, 8 insertions, 7 deletions
diff --git a/py/modbuiltins.c b/py/modbuiltins.c
index 5a0a3a3380..d12af4c2f1 100644
--- a/py/modbuiltins.c
+++ b/py/modbuiltins.c
@@ -244,10 +244,10 @@ STATIC mp_obj_t mp_builtin_input(size_t n_args, const mp_obj_t *args) {
vstr_init(&line, 16);
int ret = mp_hal_readline(&line, "");
if (ret == CHAR_CTRL_C) {
- nlr_raise(mp_obj_new_exception(&mp_type_KeyboardInterrupt));
+ mp_raise_type(&mp_type_KeyboardInterrupt);
}
if (line.len == 0 && ret == CHAR_CTRL_D) {
- nlr_raise(mp_obj_new_exception(&mp_type_EOFError));
+ mp_raise_type(&mp_type_EOFError);
}
return mp_obj_new_str_from_vstr(&mp_type_str, &line);
}
@@ -321,7 +321,7 @@ STATIC mp_obj_t mp_builtin_next(size_t n_args, const mp_obj_t *args) {
if (n_args == 1) {
mp_obj_t ret = mp_iternext_allow_raise(args[0]);
if (ret == MP_OBJ_STOP_ITERATION) {
- nlr_raise(mp_obj_new_exception(&mp_type_StopIteration));
+ mp_raise_type(&mp_type_StopIteration);
} else {
return ret;
}
@@ -335,7 +335,7 @@ MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(mp_builtin_next_obj, 1, 2, mp_builtin_next);
STATIC mp_obj_t mp_builtin_next(mp_obj_t o) {
mp_obj_t ret = mp_iternext_allow_raise(o);
if (ret == MP_OBJ_STOP_ITERATION) {
- nlr_raise(mp_obj_new_exception(&mp_type_StopIteration));
+ mp_raise_type(&mp_type_StopIteration);
} else {
return ret;
}
diff --git a/py/modthread.c b/py/modthread.c
index 5a9aba55f1..f54bf83444 100644
--- a/py/modthread.c
+++ b/py/modthread.c
@@ -271,7 +271,7 @@ STATIC mp_obj_t mod_thread_start_new_thread(size_t n_args, const mp_obj_t *args)
STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(mod_thread_start_new_thread_obj, 2, 3, mod_thread_start_new_thread);
STATIC mp_obj_t mod_thread_exit(void) {
- nlr_raise(mp_obj_new_exception(&mp_type_SystemExit));
+ mp_raise_type(&mp_type_SystemExit);
}
STATIC MP_DEFINE_CONST_FUN_OBJ_0(mod_thread_exit_obj, mod_thread_exit);
diff --git a/py/objgenerator.c b/py/objgenerator.c
index 8b387d8732..2bb96bcd05 100644
--- a/py/objgenerator.c
+++ b/py/objgenerator.c
@@ -261,7 +261,7 @@ STATIC mp_obj_t gen_instance_iternext(mp_obj_t self_in) {
STATIC mp_obj_t gen_instance_send(mp_obj_t self_in, mp_obj_t send_value) {
mp_obj_t ret = gen_resume_and_raise(self_in, send_value, MP_OBJ_NULL);
if (ret == MP_OBJ_STOP_ITERATION) {
- nlr_raise(mp_obj_new_exception(&mp_type_StopIteration));
+ mp_raise_type(&mp_type_StopIteration);
} else {
return ret;
}
@@ -288,7 +288,7 @@ STATIC mp_obj_t gen_instance_throw(size_t n_args, const mp_obj_t *args) {
mp_obj_t ret = gen_resume_and_raise(args[0], mp_const_none, exc);
if (ret == MP_OBJ_STOP_ITERATION) {
- nlr_raise(mp_obj_new_exception(&mp_type_StopIteration));
+ mp_raise_type(&mp_type_StopIteration);
} else {
return ret;
}
diff --git a/py/runtime.h b/py/runtime.h
index 063971883a..7f7a89f3f6 100644
--- a/py/runtime.h
+++ b/py/runtime.h
@@ -151,6 +151,7 @@ mp_obj_t mp_import_name(qstr name, mp_obj_t fromlist, mp_obj_t level);
mp_obj_t mp_import_from(mp_obj_t module, qstr name);
void mp_import_all(mp_obj_t module);
+#define mp_raise_type(exc_type) mp_raise_msg(exc_type, NULL)
NORETURN void mp_raise_msg(const mp_obj_type_t *exc_type, const char *msg);
NORETURN void mp_raise_ValueError(const char *msg);
NORETURN void mp_raise_TypeError(const char *msg);