diff options
author | Damien George <damien.p.george@gmail.com> | 2014-05-31 17:59:11 +0100 |
---|---|---|
committer | Damien George <damien.p.george@gmail.com> | 2014-05-31 17:59:11 +0100 |
commit | 5b5562c1d13fa0b78fd13731cebdaa911eb47726 (patch) | |
tree | 3b5b698e0c48b49cd1e896fc8dee262b952f9296 /py | |
parent | 049a01d148c757a17e9804a2b1e42c918e29b094 (diff) | |
download | micropython-5b5562c1d13fa0b78fd13731cebdaa911eb47726.tar.gz micropython-5b5562c1d13fa0b78fd13731cebdaa911eb47726.zip |
py: Fix stack underflow with optimised for loop.
Diffstat (limited to 'py')
-rw-r--r-- | py/compile.c | 2 | ||||
-rw-r--r-- | py/vm.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/py/compile.c b/py/compile.c index c90772a7e3..1f0d90570e 100644 --- a/py/compile.c +++ b/py/compile.c @@ -1745,7 +1745,7 @@ void compile_while_stmt(compiler_t *comp, mp_parse_node_struct_t *pns) { // And, if the loop never runs, the loop variable should never be assigned void compile_for_stmt_optimised_range(compiler_t *comp, mp_parse_node_t pn_var, mp_parse_node_t pn_start, mp_parse_node_t pn_end, mp_parse_node_t pn_step, mp_parse_node_t pn_body, mp_parse_node_t pn_else) { START_BREAK_CONTINUE_BLOCK - comp->break_label |= MP_EMIT_BREAK_FROM_FOR; + // note that we don't need to pop anything when breaking from an optimise for loop uint top_label = comp_next_label(comp); uint entry_label = comp_next_label(comp); @@ -159,8 +159,8 @@ mp_vm_return_kind_t mp_execute_bytecode(const byte *code, const mp_obj_t *args, #if DETECT_VM_STACK_OVERFLOW if (vm_return_kind == MP_VM_RETURN_NORMAL) { - if (sp != state) { - printf("Stack misalign: %d\n", sp - state); + if (sp < state) { + printf("VM stack underflow: " INT_FMT "\n", sp - state); assert(0); } } @@ -178,7 +178,7 @@ mp_vm_return_kind_t mp_execute_bytecode(const byte *code, const mp_obj_t *args, } } if (overflow) { - printf("VM stack overflow state=%p n_state+1=%u\n", state, n_state); + printf("VM stack overflow state=%p n_state+1=" UINT_FMT "\n", state, n_state); assert(0); } } |