diff options
| author | Damien George <damien@micropython.org> | 2024-07-18 12:35:42 +1000 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2024-07-18 12:35:42 +1000 |
| commit | e00d80d9e27552760603b507c77aad6f5705174f (patch) | |
| tree | 145f739f80f7e6b689791ffcf7a17009c9028bbe /py/objrange.c | |
| parent | fce3cea2440e0242fc4cf5c1825368795f540470 (diff) | |
| download | micropython-e00d80d9e27552760603b507c77aad6f5705174f.tar.gz micropython-e00d80d9e27552760603b507c77aad6f5705174f.zip | |
py: Remove 5 TODOs in emitbc, objrange and repl.
These TODOs don't need to be done:
- Calling functions with keyword arguments is less common than without
them, so adding an extra byte overhead to all calls regardless of whether
they use keywords or not would overall increase generated bytecode size.
- Restricting `range` objects to machine-sized ints has been adequate for
a long time now, so no need to change that and make it more complicated
and slower.
- Printing spaces in tab completion does not need to be optimised.
Signed-off-by: Damien George <damien@micropython.org>
Diffstat (limited to 'py/objrange.c')
| -rw-r--r-- | py/objrange.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/py/objrange.c b/py/objrange.c index 9a4ecd3fcd..5ccb04fba6 100644 --- a/py/objrange.c +++ b/py/objrange.c @@ -33,7 +33,6 @@ typedef struct _mp_obj_range_it_t { mp_obj_base_t base; - // TODO make these values generic objects or something mp_int_t cur; mp_int_t stop; mp_int_t step; @@ -72,7 +71,6 @@ static mp_obj_t mp_obj_new_range_iterator(mp_int_t cur, mp_int_t stop, mp_int_t typedef struct _mp_obj_range_t { mp_obj_base_t base; - // TODO make these values generic objects or something mp_int_t start; mp_int_t stop; mp_int_t step; |