summaryrefslogtreecommitdiffstatshomepage
path: root/py/objmodule.c
diff options
context:
space:
mode:
authorDamien George <damien.p.george@gmail.com>2018-09-27 15:16:24 +1000
committerDamien George <damien.p.george@gmail.com>2018-09-27 15:16:24 +1000
commit04f7da78dba7c37846a70ac108317e631950efc0 (patch)
tree51e6aa471a2686fc9c494d286e5cd4c414d2d93e /py/objmodule.c
parentcc5c3c64cad47dc6155250cd4683d302b07eac3b (diff)
downloadmicropython-04f7da78dba7c37846a70ac108317e631950efc0.tar.gz
micropython-04f7da78dba7c37846a70ac108317e631950efc0.zip
py/objmodule: Remove TODO about checking store attr to a module.
The code implements correct behaviour, as tested by basics/module1.py.
Diffstat (limited to 'py/objmodule.c')
-rw-r--r--py/objmodule.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/py/objmodule.c b/py/objmodule.c
index d2a67ffb83..4e6f175417 100644
--- a/py/objmodule.c
+++ b/py/objmodule.c
@@ -84,7 +84,6 @@ STATIC void module_attr(mp_obj_t self_in, qstr attr, mp_obj_t *dest) {
mp_obj_dict_delete(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr));
} else {
// store attribute
- // TODO CPython allows STORE_ATTR to a module, but is this the correct implementation?
mp_obj_dict_store(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr), dest[1]);
}
dest[0] = MP_OBJ_NULL; // indicate success