summaryrefslogtreecommitdiffstatshomepage
path: root/ports/unix/unix_mphal.c
diff options
context:
space:
mode:
authorDavid Lechner <david@pybricks.com>2020-01-22 18:14:03 -0600
committerDamien George <damien.p.george@gmail.com>2020-01-26 23:21:29 +1100
commitfee7e5617f55b4778de74ee185fcc3950cdc7b6d (patch)
tree9a1fec68969ee8e27e74a5e92761ae1a194580bb /ports/unix/unix_mphal.c
parent96716b46e1c4945d3fe08d9ba91920ca28f9c986 (diff)
downloadmicropython-fee7e5617f55b4778de74ee185fcc3950cdc7b6d.tar.gz
micropython-fee7e5617f55b4778de74ee185fcc3950cdc7b6d.zip
unix: Release GIL during all system calls.
Addition of GIL EXIT/ENTER pairs are: - modos: release the GIL during system calls. CPython does this as well. - moduselect: release the GIL during the poll() syscall. This call can be blocking, so it is important to allow other threads to run at this time. - modusocket: release the GIL during system calls. Many of these calls can be blocking, so it is important to allow other threads to run. - unix_mphal: release the GIL during the read and write syscalls in mp_hal_stdin_rx_chr and mp_hal_stdout_tx_strn. If we don't do this threads are blocked when the REPL or the builtin input function are used. - file, main, mpconfigport.h: release GIL during syscalls in built-in functions that could block.
Diffstat (limited to 'ports/unix/unix_mphal.c')
-rw-r--r--ports/unix/unix_mphal.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/ports/unix/unix_mphal.c b/ports/unix/unix_mphal.c
index 9b009dc502..3e14409efb 100644
--- a/ports/unix/unix_mphal.c
+++ b/ports/unix/unix_mphal.c
@@ -31,6 +31,7 @@
#include <sys/time.h>
#include "py/mphal.h"
+#include "py/mpthread.h"
#include "py/runtime.h"
#include "extmod/misc.h"
@@ -160,7 +161,9 @@ int mp_hal_stdin_rx_chr(void) {
} else {
main_term:;
#endif
+ MP_THREAD_GIL_EXIT();
int ret = read(0, &c, 1);
+ MP_THREAD_GIL_ENTER();
if (ret == 0) {
c = 4; // EOF, ctrl-D
} else if (c == '\n') {
@@ -173,7 +176,9 @@ int mp_hal_stdin_rx_chr(void) {
}
void mp_hal_stdout_tx_strn(const char *str, size_t len) {
+ MP_THREAD_GIL_EXIT();
int ret = write(1, str, len);
+ MP_THREAD_GIL_ENTER();
mp_uos_dupterm_tx_strn(str, len);
(void)ret; // to suppress compiler warning
}