aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/app
Commit message (Collapse)AuthorAge
...
* Reduce undeeded use of elvis operator ?: (#7204)Alexandre Alapetite2025-01-10
|
* Fix continuous mode (#7200)Alexandre Alapetite2025-01-08
| | | fix https://github.com/FreshRSS/FreshRSS/issues/7199
* Fix sharing integration (#7198)Alexandre Alapetite2025-01-08
| | | fix https://github.com/FreshRSS/FreshRSS/issues/7192
* Add some missing PHP native types (#7191)Alexandre Alapetite2025-01-08
| | | | | | * Add some missing PHP native types Replaces https://github.com/FreshRSS/FreshRSS/pull/7184 * Clean some types
* i18n: Japanese (#7195)hkcomori2025-01-08
|
* i18n: Japanese (#7187)hkcomori2025-01-07
| | | | | | * i18n: Japanese * Fix typo
* Implement custom order-by (#7149)Alexandre Alapetite2025-01-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add option to sort results by received date (existing, default), publication date, title, URL (link), random. fix https://github.com/FreshRSS/FreshRSS/issues/1771 fix https://github.com/FreshRSS/FreshRSS/issues/2083 fix https://github.com/FreshRSS/FreshRSS/issues/2119 fix https://github.com/FreshRSS/FreshRSS/issues/2596 fix https://github.com/FreshRSS/FreshRSS/issues/3204 fix https://github.com/FreshRSS/FreshRSS/issues/4405 fix https://github.com/FreshRSS/FreshRSS/issues/5529 fix https://github.com/FreshRSS/FreshRSS/issues/5864 fix https://github.com/FreshRSS/Extensions/issues/161 URL parameters: * `&sort=id` (current behaviour, sorting according to newest received articles) * `&sort=date` (publication date, which is not indicative of how new an article is) * `&sort=title` * `&sort=link` * `&sort=rand` (random order - which disables infinite scrolling, at least for now) combined with `&order=ASC` or `&order=DESC` ![image](https://github.com/user-attachments/assets/2de5aef1-604e-4a73-a147-569f6f42a1be) ## Implementation notes The sorting criteria by *received date* (id), which is the default, and which was the only one before this PR, is the one that has the best sorting characteristics: * *uniqueness*: no entries have the exact same received date * *monotonicity*: new entries always have a higher received date * *performance*: this field is efficiently indexed in database for fast usage, including for paging (indexing could also be done to other fields, but with lower effective performance) In contrary, sorting criteria such as by *publication date*, by *title*, or by *link* are neither unique nor monotonic. In particular, multiple articles may share the same *publication date*, and we may receive articles with a *publication date* far in the future, and then later some new articles with a *publication date* far in the past. To understand why sorting by *publication date* is problematic, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. ### Problem 1: new articles New articles may be received in the background after what is shown on screen, and before the next user action such as *mark all as read*. Due to the lack of *monotonicity* when sorting by e.g. *publication date* or *title*, users risk marking as read a batch of articles containing some fresh articles without seeing them. Mitigation: A parameter `idMax` tracks the maximum ID related to a batch of actions such as *mark all as read* to exclude articles received after those that are displayed. ### Problem 2: paging / pagination When navigating articles, only a few articles are displayed, and a new "page" of articles needs to be received from the database when scrolling down or when clicking the button to show more articles. When sorting by e.g. *publication date* or *title*, it is not trivial to show the next page without re-showing some of the same articles, and without skipping any. Indeed, views are often with additional criteria such as showing only unread articles, and users may mark some articles as read while viewing them, hereby removing some articles from the previous pages. And like for *Problem 1*, new articles may have been received in the background. Consequently, it is not possible to use `OFFSET` to implement pagination (so the patches suggested by a few users were wrong due to that, in particular). Mitigation: `idMax` is also used (just like for *Problem 1*) and a *Keyset Pagination* approach is used, combining an unstable sorting criterion such as *publication date* or *title*, together with *id* to ensure stable sorting. (So, 2 sorting criteria + 1 filter criteria) See e.g. https://www.alwaysdeveloping.net/dailydrop/2022/07/01-keyset-pagination/ ### Problem 3: performance Sorting by anything else than *received date* (id) is doomed to be slow(er) due to the combination of 3 criteria (see *Problem 2*). An `OFFSET` approach (which is not possible anyway as explained) would be even slower. Furthermore, we have no SQL index at the moment, but they would not necessarily help much due to the multiple sorting criteria needed and involving some `OR` logic which is difficult to optimise for databases. The nicest syntax would be using tuples and corresponding indexes, but that is poorly supported by MySQL https://bugs.mysql.com/bug.php?id=104128 Mitigation: a compatibility SQL syntax is used to implement *Keyset Pagination* ### Problem 4: user confusion Several users have shown that they do not fully understand the difference between *received date* and *publication date*, and particularly not the pitfalls of *publication date*. Mitigation: the menus to mark-as-read *before 1 day* and *before 1 week* are disabled when sorting by anything else than *received date*. Likewise, the separation headers *Today* and *Yesterday* and *Before yesterday* are only shown when sorting by *received date*. Again here, to better understand why, it helps to think about sorting by *title* or by *link*, as sorting by *title* and by *publication date* share more or less the same characteristics. * [ ] We should write a Q&A and/or documentation about the problems associated to *sorting by publication date*: risks of not noticing new publication, of inadvertently marking them as read, of having some articles with a date in the future hanging at the top of the views (vice versa when sorting in ascending order), performance, etc. ### Problem 5: APIs Sorting by anything else than *received date* breaks the guarantees needed for a successful synchronisation via API. Mitigation: sorting by *received date* is ensured for all API calls.
* fix i18n:de sub.php (#7177)maTh2025-01-05
|
* Bump phpstan/phpstan from 2.0.4 to 2.1.0 (#7164)dependabot[bot]2025-01-01
| | | | | | | | | | | | | | | | | | | | | | | | | * Bump phpstan/phpstan from 2.0.4 to 2.1.0 Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 2.0.4 to 2.1.0. - [Release notes](https://github.com/phpstan/phpstan/releases) - [Changelog](https://github.com/phpstan/phpstan/blob/2.1.x/CHANGELOG.md) - [Commits](https://github.com/phpstan/phpstan/compare/2.0.4...2.1.0) --- updated-dependencies: - dependency-name: phpstan/phpstan dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Workaround false positive PHPStan --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* templates and i18n: link back to rss feeds (#7162)maTh2024-12-29
|
* Fix regressions on some array structures (#7155)Alexandre Alapetite2024-12-28
| | | | regressions from https://github.com/FreshRSS/FreshRSS/pull/7131 fix https://github.com/FreshRSS/FreshRSS/issues/7154
* Fix regression labels (#7150)Alexandre Alapetite2024-12-27
| | | Regression from https://github.com/FreshRSS/FreshRSS/pull/7131
* PHPStan 2.0 (#7131)Alexandre Alapetite2024-12-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * PHPStan 2.0 fix https://github.com/FreshRSS/FreshRSS/issues/6989 https://github.com/phpstan/phpstan/releases/tag/2.0.0 https://github.com/phpstan/phpstan/blob/2.0.x/UPGRADING.md * More * More * Done * fix i18n CLI * Restore a PHPStan Next test For work towards PHPStan Level 10 * 4 more on Level 10 * fix getTagsForEntry * API at Level 10 * More Level 10 * Finish Minz at Level 10 * Finish CLI at Level 10 * Finish Controllers at Level 10 * More Level 10 * More * Pass bleedingEdge * Clean PHPStan options and add TODOs * Level 10 for main config * More * Consitency array vs. list * Sanitize themes get_infos * Simplify TagDAO->getTagsForEntries() * Finish reportAnyTypeWideningInVarTag * Prepare checkBenevolentUnionTypes and checkImplicitMixed * Fixes * Refix * Another fix * Casing of __METHOD__ constant
* Search in all feeds (#7144)Alexandre Alapetite2024-12-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Search in all feeds Search in PRIORITY_ARCHIVED with `&get=A` fix https://github.com/FreshRSS/FreshRSS/discussions/7143 * Fix type * Search in PRIORITY_ARCHIVED with `&get=Z` * More * Fixes * One more fix * Extra features in user queries * Move i18n key * Fix overview * Enlarge query boxes * Revert i18n spelling * i18n: it Thanks @UserRoot-Luca Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
* new: reader view: footer has manage icons (#7133)maTh2024-12-26
| | | | | | | | | * add footer * rename content thin medium large class * rework css * footer improved
* Allow privacy page to non admins (#7132)Alexandre Alapetite2024-12-22
| | | fix https://github.com/FreshRSS/FreshRSS/issues/7123
* i18n:de Update admin.php (#7128)maTh2024-12-21
|
* Add share link Bluesky (#7116)UserRoot-Luca2024-12-19
| | | | | | | | | | | * Add share link bluesky * Update * make fix-all --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* fix: sharing menu entry id (#7113)maTh2024-12-18
| | | | | * fix sharing menu entry id * Update main.js
* New state: favorite or unread (#7088)Alexandre Alapetite2024-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * New state: favorite or unread https://github.com/FreshRSS/FreshRSS/discussions/7078#discussioncomment-11526292 * Experiment using this state by default * Rework state * Allow ANDS for typos * Revert change unrelated to this PR * Revert change of default state * Add option *unread_or_favorite* * Fix hide_read_feeds * i18n: it Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * Update app/i18n/pl/conf.php Co-authored-by: Zic <55097497+ZicPL@users.noreply.github.com> * Update app/i18n/pl/conf.php Co-authored-by: Zic <55097497+ZicPL@users.noreply.github.com> * Fix i18n * Fix auto_remove_article * Fix mark_unread_enabled --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Zic <55097497+ZicPL@users.noreply.github.com>
* Matching category colors across pie-charts (#7090)kwarraich2024-12-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Trying to implement linkace as a sharing method, related to issue 6698. it's in the files now and shows up but is not sharing properly now * creating a colour palette based on the number of categories, then making it into hex values to use later * assigning categories with specific colors to make sure the colors are consistent in the graph * adjusted pychart logic to account for unique assignments of each categoery with the colours * fixing redundant code blocks * removing extra uneeded code -an accidental commit * removed changes unrelated to PR * fixed linting errors * refactored color palette to use CSS native hsl() colors * Fix whitespace --------- Co-authored-by: rsharaf-dev <rsharaf@andrew.cmu.edu> Co-authored-by: roma2023 <romasaparhan19@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Improved CSS filter (#7091)Alexandre Alapetite2024-12-11
| | | | | | | | | * Improved CSS filter Remove unwanted elements both before and after sanitizing fix https://github.com/FreshRSS/FreshRSS/issues/7084 Improved fix bug in https://github.com/FreshRSS/FreshRSS/commit/33fd07f6f26310d4806077cc87bcdf9b8b940e35#commitcomment-150152171 * fix typing
* I18n Italian update (#7086)UserRoot-Luca2024-12-10
|
* Fix CSS filter help message (#7083)Alexandre Alapetite2024-12-10
| | | https://github.com/FreshRSS/FreshRSS/issues/7014#issuecomment-2531610211
* OPML export/import for cssFullContentConditions (#7082)Alexandre Alapetite2024-12-10
| | | Follow-up of https://github.com/FreshRSS/FreshRSS/commit/33fd07f6f26310d4806077cc87bcdf9b8b940e35, which should have been a PR.
* Fix string conditionAlexandre Alapetite2024-12-10
| | | | Follow-up of https://github.com/FreshRSS/FreshRSS/commit/33fd07f6f26310d4806077cc87bcdf9b8b940e35 , which should have been a PR
* Conditional retrievalAlexandre Alapetite2024-12-10
| | | | fix https://github.com/FreshRSS/FreshRSS/issues/6149
* Fix regression CSS filter encoding (#7081)Alexandre Alapetite2024-12-10
| | | | fix Unicode of https://github.com/FreshRSS/FreshRSS/pull/7073 Plus optimisation of XPath by keeping it into a variable.
* Sanitize before CSS manipulation (#7073)Alexandre Alapetite2024-12-08
| | | | | | Allows using the same CSS filters for content coming from RSS feeds and from Web scraping fix https://github.com/FreshRSS/FreshRSS/issues/7039 https://github.com/FreshRSS/FreshRSS/issues/7014#issuecomment-2508987606 https://github.com/FreshRSS/FreshRSS/pull/7037
* Fixed: No user query - no information (#7062)maTh2024-12-08
| | | | | | | | | | | | | | | | | | | | | | | | * Update queries.phtml * i18n * fix _blank target * No user queries are saved yet * Update app/i18n/it/conf.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * Update app/i18n/it/conf.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * Update app/i18n/fr/conf.php --------- Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* i18n: german (#7068)maTh2024-12-08
| | | | | * part1 * Update sub.php
* i18n: Italian (#7069)UserRoot-Luca2024-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * i18n: Italian Italian translation * Update app/i18n/it/conf.php Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update app/i18n/it/sub.php * Update * Update app/i18n/it/sub.php Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update app/i18n/it/sub.php Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update app/i18n/it/sub.php Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * Update --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Fix invalid login message (#7066)Alexandre Alapetite2024-12-05
| | | fix https://github.com/FreshRSS/FreshRSS/issues/7061
* Avoid Unicode escape of authors in HTML UI (#7056)Alexandre Alapetite2024-12-05
| | | fix https://github.com/FreshRSS/FreshRSS/issues/2770
* Parentheses in quoted search (#7055)Alexandre Alapetite2024-12-05
| | | | | | | * Parentheses in quoted search Allow parentheses in quoted search like `author:"Bob (Team1)"` Related to https://github.com/FreshRSS/FreshRSS/pull/7054 * Doc
* Rework UI authors (#7054)Alexandre Alapetite2024-12-05
| | | | Add separators, and mutualise code fix https://github.com/FreshRSS/FreshRSS/issues/7032
* Revert "Implement showing and hiding header depending on scroll (#7029)" (#7064)Alexandre Alapetite2024-12-05
| | | | This reverts commit be9b6c7290dddcd8b8b6a8926bd101b7123528b3. https://github.com/FreshRSS/FreshRSS/pull/7029
* improve api management (#7048)maTh2024-12-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ... and sharing user queries by link (not all languages) * Profile page: API mgm: better headline, better help text * i18n * i18n: " and sharing user queries" * i18n: link to documentation + apps list * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/conf.php * Update app/i18n/it/admin.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * Update app/i18n/it/conf.php * Update app/i18n/fr/admin.php * i18n * French doc cf. English * Update app/i18n/it/conf.php Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com> * Update conf.php --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: UserRoot-Luca <55756898+UserRoot-Luca@users.noreply.github.com>
* #4870 opml category text field (#7053)killerog2024-12-04
| | | | | | | | | | | | | | | | * Added OPML import field description * Update CREDITS.md Almost forgot to add myself to the credits * make fix-all * i18n:fr --------- Co-authored-by: Rogier Schoenmaker <rogier@spreadit.nl> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Implement showing and hiding header depending on scroll (#7029)Frans de Jonge2024-12-04
| | | | | | | | | | | | | | | | | * Implement showing and hiding header depending on scroll References #7011. * header.phtml: adjust indentation * minor efficiency improvement * Update p/scripts/main.js Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Fallback to GUID if article link is empty (#7051)Alexandre Alapetite2024-12-03
| | | | | | * Fallback to GUID is entry link is empty fix https://github.com/FreshRSS/FreshRSS/issues/7050 * FILTER_NULL_ON_FAILURE
* i18n: "still reachable" (#7049)Alexandre Alapetite2024-12-03
| | | | | | | | | | | | | | | | | | | * i18n: "still reachable" fix wording https://github.com/FreshRSS/FreshRSS/pull/7030#discussion_r1866650296 and address risk of confusion https://github.com/FreshRSS/FreshRSS/issues/7025#issuecomment-2509400455 * Fix English * Rewording * Update app/i18n/nl/sub.php Co-authored-by: Frans de Jonge <fransdejonge@gmail.com> --------- Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
* New button to delete errored feeds from a category (#7030)Alexandre Alapetite2024-12-03
| | | | | | | | | | | * New button to delete errored feeds from a category fix https://github.com/FreshRSS/FreshRSS/issues/7025 fix https://github.com/FreshRSS/FreshRSS/issues/7026 * Remove English TODO * in error state * Feeds with errors
* Fix CSS selector for removing elements (#7037)Alexandre Alapetite2024-11-30
| | | | fix https://github.com/FreshRSS/FreshRSS/issues/7014 Case of negative filter matching the positive filter
* article footer small display (#7031)maTh2024-11-30
|
* Upgrade code to php 8.1 (#6748)Luc SANCHEZ2024-11-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * revert Fix code indentation Fix code Upgrade code to php 8.1 * fix remarques * code review * code review * code review * Apply suggestions from code review * code review * Fixes * Many remainging updates of array syntax * Lost case 'reading-list' * Uneeded PHPDoc --------- Co-authored-by: Luc Sanchez <l.sanchez-prestataire@alptis.fr> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
* Fix tag ID uniqueness (#6990)Alexandre Alapetite2024-11-25
| | | | | | | | | | | | * Fix tag ID uniqueness fix https://github.com/FreshRSS/FreshRSS/pull/6052#discussion_r1837266309 * Update app/views/helpers/index/tags.phtml Co-authored-by: maTh <1645099+math-GH@users.noreply.github.com> --------- Co-authored-by: maTh <1645099+math-GH@users.noreply.github.com>
* Add extension hook simplepie_after_init (#7007)Alexandre Alapetite2024-11-21
| | | | | | | | | | | | * Add extension hook simplepie_after_init fix https://github.com/FreshRSS/FreshRSS/issues/7006 * Add documentation note * fix doc get_headers * Syntax void * Forgotten code
* Fix HTML pattern in install (#7009)Alexandre Alapetite2024-11-19
| | | | | | | | | | | | | Slashes now need to be escaped because of `v` mode: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Character_class#v-mode_character_class https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/pattern#overview Edge: > Pattern attribute value [0-9A-Z/a-z_.\-]{1,64}(:[0-9]{2,5})? is not a valid regular expression: Uncaught SyntaxError: Invalid regular expression: /[0-9A-Z/a-z_.\-]{1,64}(:[0-9]{2,5})?/v: Invalid character in character class Firefox: > Impossible de vérifier <input pattern='[0-9A-Z/a-z_.\-]{1,64}(:[0-9]{2,5})?'> car « /[0-9A-Z/a-z_.\-]{1,64}(:[0-9]{2,5})?/v » n’est pas une expression régulière valide : invalid character in class in regular expression
* Avoid race condition in users' homedir creation (#7000)Andriy Utkin2024-11-18
|
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-30 14:24:29 +0000