1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
|
<?php
declare(strict_types=1);
namespace Drupal\Tests\file\Functional;
use Drupal\Component\Utility\Html;
use Drupal\Core\File\FileExists;
use Drupal\Core\Url;
use Drupal\file\Entity\File;
use Drupal\file_test\FileTestHelper;
use Drupal\Tests\TestFileCreationTrait;
// cSpell:ignore TÉXT Pácê
/**
* Tests the file_save_upload() function.
*
* @group file
*/
class SaveUploadTest extends FileManagedTestBase {
use TestFileCreationTrait {
getTestFiles as drupalGetTestFiles;
}
/**
* {@inheritdoc}
*/
protected static $modules = ['dblog', 'file_validator_test'];
/**
* {@inheritdoc}
*/
protected $defaultTheme = 'stark';
/**
* An image file path for uploading.
*
* @var \Drupal\file\FileInterface
*/
protected $image;
/**
* A PHP file path for upload security testing.
*
* @var string
*/
protected $phpFile;
/**
* The largest file id when the test starts.
*
* @var int
*/
protected $maxFidBefore;
/**
* Extension of the image filename.
*
* @var string
*/
protected $imageExtension;
/**
* The user used by the test.
*
* @var \Drupal\user\Entity\User
*/
protected $account;
/**
* {@inheritdoc}
*/
protected function setUp(): void {
parent::setUp();
$this->account = $this->drupalCreateUser(['access site reports']);
$this->drupalLogin($this->account);
$image_files = $this->drupalGetTestFiles('image');
$this->image = File::create((array) current($image_files));
[, $this->imageExtension] = explode('.', $this->image->getFilename());
$this->assertFileExists($this->image->getFileUri());
$this->phpFile = current($this->drupalGetTestFiles('php'));
$this->assertFileExists($this->phpFile->uri);
$this->maxFidBefore = (int) \Drupal::entityQueryAggregate('file')
->accessCheck(FALSE)
->aggregate('fid', 'max')
->execute()[0]['fid_max'];
// Upload with replace to guarantee there's something there.
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Check that the success message is present.
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called then clean out the hook
// counters.
$this->assertFileHooksCalled(['validate', 'insert']);
FileTestHelper::reset();
}
/**
* Tests the file_save_upload() function.
*/
public function testNormal(): void {
$max_fid_after = (int) \Drupal::entityQueryAggregate('file')
->accessCheck(FALSE)
->aggregate('fid', 'max')
->execute()[0]['fid_max'];
// Verify that a new file was created.
$this->assertGreaterThan($this->maxFidBefore, $max_fid_after);
$file1 = File::load($max_fid_after);
$this->assertInstanceOf(File::class, $file1);
// MIME type of the uploaded image may be either image/jpeg or image/png.
$this->assertEquals('image', substr($file1->getMimeType(), 0, 5), 'A MIME type was set.');
// Reset the hook counters to get rid of the 'load' we just called.
FileTestHelper::reset();
// Upload a second file.
$image2 = current($this->drupalGetTestFiles('image'));
$edit = ['files[file_test_upload]' => \Drupal::service('file_system')->realpath($image2->uri)];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("You WIN!");
$max_fid_after = (int) \Drupal::entityQueryAggregate('file')
->accessCheck(FALSE)
->aggregate('fid', 'max')
->execute()[0]['fid_max'];
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
$file2 = File::load($max_fid_after);
$this->assertInstanceOf(File::class, $file2);
// MIME type of the uploaded image may be either image/jpeg or image/png.
$this->assertEquals('image', substr($file2->getMimeType(), 0, 5), 'A MIME type was set.');
// Load both files using File::loadMultiple().
$files = File::loadMultiple([$file1->id(), $file2->id()]);
$this->assertTrue(isset($files[$file1->id()]), 'File was loaded successfully');
$this->assertTrue(isset($files[$file2->id()]), 'File was loaded successfully');
// Upload a third file to a subdirectory.
$image3 = current($this->drupalGetTestFiles('image'));
$image3_realpath = \Drupal::service('file_system')->realpath($image3->uri);
$dir = $this->randomMachineName();
$edit = [
'files[file_test_upload]' => $image3_realpath,
'file_subdir' => $dir,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("You WIN!");
$this->assertFileExists('temporary://' . $dir . '/' . trim(\Drupal::service('file_system')->basename($image3_realpath)));
}
/**
* Tests uploading a duplicate file.
*/
public function testDuplicate(): void {
// It should not be possible to create two managed files with the same URI.
$image1 = current($this->drupalGetTestFiles('image'));
$edit = ['files[file_test_upload]' => \Drupal::service('file_system')->realpath($image1->uri)];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$max_fid_after = (int) \Drupal::entityQueryAggregate('file')
->accessCheck(FALSE)
->aggregate('fid', 'max')
->execute()[0]['fid_max'];
$file1 = File::load($max_fid_after);
// Simulate a race condition where two files are uploaded at almost the same
// time, by removing the first uploaded file from disk (leaving the entry in
// the file_managed table) before trying to upload another file with the
// same name.
unlink(\Drupal::service('file_system')->realpath($file1->getFileUri()));
$image2 = $image1;
$edit = ['files[file_test_upload]' => \Drupal::service('file_system')->realpath($image2->uri)];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
// Received a 200 response for posted test file.
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("The file {$file1->getFileUri()} already exists. Enter a unique file URI.");
$max_fid_before_duplicate = $max_fid_after;
$max_fid_after = (int) \Drupal::entityQueryAggregate('file')
->accessCheck(FALSE)
->aggregate('fid', 'max')
->execute()[0]['fid_max'];
$this->assertEquals($max_fid_before_duplicate, $max_fid_after, 'A new managed file was not created.');
}
/**
* Tests extension handling.
*/
public function testHandleExtension(): void {
// The file being tested is a .gif which is in the default safe list
// of extensions to allow when the extension validator isn't used. This is
// implicitly tested at the testNormal() test. Here we tell
// file_save_upload() to only allow ".foo".
$extensions = 'foo';
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'extensions' => $extensions,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('Only files with the following extensions are allowed: <em class="placeholder">' . $extensions . '</em>');
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
// Reset the hook counters.
FileTestHelper::reset();
$extensions = 'foo ' . $this->imageExtension;
// Now tell file_save_upload() to allow the extension of our test image.
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'extensions' => $extensions,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains("Only files with the following extensions are allowed:");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'load', 'update']);
// Reset the hook counters.
FileTestHelper::reset();
// Now tell file_save_upload() to allow any extension.
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'allow_all_extensions' => 'empty_array',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains("Only files with the following extensions are allowed:");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'load', 'update']);
// Reset the hook counters.
FileTestHelper::reset();
// Now tell file_save_upload() to allow any extension and try and upload a
// malicious file.
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->phpFile->uri),
'allow_all_extensions' => 'empty_array',
'is_image_file' => FALSE,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('For security reasons, your upload has been renamed to <em class="placeholder">' . $this->phpFile->filename . '_.txt</em>');
$this->assertSession()->pageTextContains('File name is php-2.php_.txt.');
$this->assertSession()->pageTextContains('File MIME type is text/plain.');
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
}
/**
* Tests dangerous file handling.
*/
public function testHandleDangerousFile(): void {
$config = $this->config('system.file');
// Allow the .php extension and make sure it gets munged and given a .txt
// extension for safety. Also check to make sure its MIME type was changed.
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->phpFile->uri),
'is_image_file' => FALSE,
'extensions' => 'php txt',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('For security reasons, your upload has been renamed to <em class="placeholder">' . $this->phpFile->filename . '_.txt</em>');
$this->assertSession()->pageTextContains('File name is php-2.php_.txt.');
$this->assertSession()->pageTextContains('File MIME type is text/plain.');
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Ensure dangerous files are not renamed when insecure uploads is TRUE.
// Turn on insecure uploads.
$config->set('allow_insecure_uploads', 1)->save();
// Reset the hook counters.
FileTestHelper::reset();
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains('File name is php-2.php.');
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
// Even with insecure uploads allowed, the .php file should not be uploaded
// if it is not explicitly included in the list of allowed extensions.
$edit['extensions'] = 'foo';
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('Only files with the following extensions are allowed: <em class="placeholder">' . $edit['extensions'] . '</em>');
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
// Reset the hook counters.
FileTestHelper::reset();
// Turn off insecure uploads, then try the same thing as above (ensure that
// the .php file is still rejected since it's not in the list of allowed
// extensions).
$config->set('allow_insecure_uploads', 0)->save();
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('Only files with the following extensions are allowed: <em class="placeholder">' . $edit['extensions'] . '</em>');
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
// Reset the hook counters.
FileTestHelper::reset();
\Drupal::service('cache.config')->deleteAll();
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->phpFile->uri),
'is_image_file' => FALSE,
'extensions' => 'php',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been rejected.');
$this->assertSession()->pageTextContains('Epic upload FAIL!');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
}
/**
* Test dangerous file handling.
*/
public function testHandleDotFile(): void {
$dot_file = $this->siteDirectory . '/.test';
file_put_contents($dot_file, 'This is a test');
$config = $this->config('system.file');
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($dot_file),
'is_image_file' => FALSE,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('The specified file .test could not be uploaded');
$this->assertSession()->pageTextContains('Epic upload FAIL!');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
$edit = [
'file_test_replace' => FileExists::Rename->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($dot_file),
'is_image_file' => FALSE,
'allow_all_extensions' => 'empty_array',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed to test.');
$this->assertSession()->pageTextContains('File name is test.');
$this->assertSession()->pageTextContains('You WIN!');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
// Turn off insecure uploads, then try the same thing as above to ensure dot
// files are renamed regardless.
$config->set('allow_insecure_uploads', 0)->save();
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed to test_0.');
$this->assertSession()->pageTextContains('File name is test_0.');
$this->assertSession()->pageTextContains('You WIN!');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
}
/**
* Tests file munge handling.
*/
public function testHandleFileMunge(): void {
// Ensure insecure uploads are disabled for this test.
$this->config('system.file')->set('allow_insecure_uploads', 0)->save();
$original_image_uri = $this->image->getFileUri();
/** @var \Drupal\file\FileRepositoryInterface $file_repository */
$file_repository = \Drupal::service('file.repository');
$this->image = $file_repository->move($this->image, $original_image_uri . '.foo.' . $this->imageExtension);
// Reset the hook counters to get rid of the 'move' we just called.
FileTestHelper::reset();
$extensions = $this->imageExtension;
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'extensions' => $extensions,
];
$munged_filename = $this->image->getFilename();
$munged_filename = substr($munged_filename, 0, strrpos($munged_filename, '.'));
$munged_filename .= '_.' . $this->imageExtension;
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is $munged_filename");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
// Ensure we don't munge the .foo extension if it is in the list of allowed
// extensions.
$extensions = 'foo ' . $this->imageExtension;
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'extensions' => $extensions,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is {$this->image->getFilename()}");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Ensure we don't munge files if we're allowing any extension.
$this->image = $file_repository->move($this->image, $original_image_uri . '.foo.txt.' . $this->imageExtension);
// Reset the hook counters.
FileTestHelper::reset();
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'allow_all_extensions' => 'empty_array',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is {$this->image->getFilename()}");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Test that a dangerous extension such as .php is munged even if it is in
// the list of allowed extensions.
$this->image = $file_repository->move($this->image, $original_image_uri . '.php.' . $this->imageExtension);
// Reset the hook counters.
FileTestHelper::reset();
$extensions = 'php ' . $this->imageExtension;
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'extensions' => $extensions,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is image-test.png_.php_.png");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
// Dangerous extensions are munged even when all extensions are allowed.
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'allow_all_extensions' => 'empty_array',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is image-test.png_.php__0.png");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Dangerous extensions are munged if is renamed to end in .txt.
$this->image = $file_repository->move($this->image, $original_image_uri . '.cgi.' . $this->imageExtension . '.txt');
// Reset the hook counters.
FileTestHelper::reset();
// Dangerous extensions are munged even when all extensions are allowed.
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'allow_all_extensions' => 'empty_array',
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("File name is image-test.png_.cgi_.png_.txt");
$this->assertSession()->pageTextContains("You WIN!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
// Reset the hook counters.
FileTestHelper::reset();
// Ensure that setting $validators['FileExtension'] = ['extensions' = '']
// rejects all files without munging or renaming.
$edit = [
'files[file_test_upload][]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
'allow_all_extensions' => 'empty_string',
];
$this->drupalGet('file-test/save_upload_from_form_test');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextNotContains('For security reasons, your upload has been renamed');
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate']);
}
/**
* Tests renaming when uploading over a file that already exists.
*/
public function testExistingRename(): void {
$edit = [
'file_test_replace' => FileExists::Rename->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("You WIN!");
$this->assertSession()->pageTextContains('File name is image-test_0.png.');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'insert']);
}
/**
* Tests replacement when uploading over a file that already exists.
*/
public function testExistingReplace(): void {
$edit = [
'file_test_replace' => FileExists::Replace->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("You WIN!");
$this->assertSession()->pageTextContains('File name is image-test.png.');
// Check that the correct hooks were called.
$this->assertFileHooksCalled(['validate', 'load', 'update']);
}
/**
* Tests for failure when uploading over a file that already exists.
*/
public function testExistingError(): void {
$edit = [
'file_test_replace' => FileExists::Error->name,
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($this->image->getFileUri()),
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Check that the no hooks were called while failing.
$this->assertFileHooksCalled([]);
}
/**
* Tests for no failures when not uploading a file.
*/
public function testNoUpload(): void {
$this->drupalGet('file-test/upload');
$this->submitForm([], 'Submit');
$this->assertSession()->pageTextNotContains("Epic upload FAIL!");
}
/**
* Tests for log entry on failing destination.
*/
public function testDrupalMovingUploadedFileError(): void {
// Create a directory and make it not writable.
$test_directory = 'test_drupal_move_uploaded_file_fail';
/** @var \Drupal\Core\File\FileSystemInterface $file_system */
$file_system = \Drupal::service('file_system');
$file_system->mkdir('temporary://' . $test_directory, 0000);
$this->assertDirectoryExists('temporary://' . $test_directory);
$edit = [
'file_subdir' => $test_directory,
'files[file_test_upload]' => $file_system->realpath($this->image->getFileUri()),
];
\Drupal::state()->set('file_test.disable_error_collection', TRUE);
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->pageTextContains('File upload error. Could not move uploaded file.');
$this->assertSession()->pageTextContains("Epic upload FAIL!");
// Uploading failed. Now check the log.
$this->drupalGet('admin/reports/dblog');
$this->assertSession()->statusCodeEquals(200);
// The full log message is in the title attribute of the link, so we cannot
// use ::pageTextContains() here.
$destination = 'temporary://' . $test_directory . '/' . $this->image->getFilename();
$this->assertSession()->responseContains("Upload error. Could not move uploaded file {$this->image->getFilename()} to destination {$destination}.");
}
/**
* Tests that filenames containing invalid UTF-8 are rejected.
*/
public function testInvalidUtf8FilenameUpload(): void {
$this->drupalGet('file-test/upload');
// Filename containing invalid UTF-8.
$filename = "x\xc0xx.gif";
$page = $this->getSession()->getPage();
$data = [
'multipart' => [
[
'name' => 'file_test_replace',
'contents' => FileExists::Rename->name,
],
[
'name' => 'form_id',
'contents' => '_file_test_form',
],
[
'name' => 'form_build_id',
'contents' => $page->find('hidden_field_selector', ['hidden_field', 'form_build_id'])->getAttribute('value'),
],
[
'name' => 'form_token',
'contents' => $page->find('hidden_field_selector', ['hidden_field', 'form_token'])->getAttribute('value'),
],
[
'name' => 'op',
'contents' => 'Submit',
],
[
'name' => 'files[file_test_upload]',
'contents' => 'Test content',
'filename' => $filename,
],
],
'cookies' => $this->getSessionCookies(),
'http_errors' => FALSE,
];
$this->assertFileDoesNotExist('temporary://' . $filename);
// Use Guzzle's HTTP client directly so we can POST files without having to
// write them to disk. Not all filesystem support writing files with invalid
// UTF-8 filenames.
$response = $this->getHttpClient()->request('POST', Url::fromUri('base:file-test/upload')->setAbsolute()->toString(), $data);
$content = (string) $response->getBody();
$this->htmlOutput($content);
$error_text = 'The file <em class="placeholder">' . Html::escape($filename) . '</em> could not be uploaded because the name is invalid.';
$this->assertStringContainsString($error_text, $content);
$this->assertStringContainsString('Epic upload FAIL!', $content);
$this->assertFileDoesNotExist('temporary://' . $filename);
}
/**
* Tests the file_save_upload() function when the field is required.
*/
public function testRequired(): void {
// Reset the hook counters to get rid of the 'load' we just called.
FileTestHelper::reset();
// Confirm the field is required.
$this->drupalGet('file-test/upload_required');
$this->submitForm([], 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('field is required');
// Confirm that uploading another file works.
$image = current($this->drupalGetTestFiles('image'));
$edit = ['files[file_test_upload]' => \Drupal::service('file_system')->realpath($image->uri)];
$this->drupalGet('file-test/upload_required');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
$this->assertSession()->responseContains('You WIN!');
}
/**
* Tests filename sanitization.
*/
public function testSanitization(): void {
$file = $this->generateFile('TÉXT-œ', 64, 5, 'text');
$this->drupalGet('file-test/upload');
// Upload a file with a name with uppercase and unicode characters.
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($file),
'extensions' => 'txt',
'is_image_file' => FALSE,
];
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has not been sanitized.
$this->assertSession()->responseContains('File name is TÉXT-œ.txt.');
// Enable sanitization via the UI.
$admin = $this->createUser(['administer site configuration']);
$this->drupalLogin($admin);
// For now, just transliterate, with no other transformations.
$options = [
'filename_sanitization[transliterate]' => TRUE,
'filename_sanitization[replace_whitespace]' => FALSE,
'filename_sanitization[replace_non_alphanumeric]' => FALSE,
'filename_sanitization[deduplicate_separators]' => FALSE,
'filename_sanitization[lowercase]' => FALSE,
'filename_sanitization[replacement_character]' => '-',
];
$this->drupalGet('admin/config/media/file-system');
$this->submitForm($options, 'Save configuration');
$this->drupalLogin($this->account);
// Upload a file with a name with uppercase and unicode characters.
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has been transliterated.
$this->assertSession()->responseContains('File name is TEXT-oe.txt.');
// Make sure we got a message about the rename.
$message = 'Your upload has been renamed to <em class="placeholder">TEXT-oe.txt</em>';
$this->assertSession()->responseContains($message);
// Generate another file with a name with All The Things(tm) we care about.
$file = $this->generateFile('S Pácê--táb# #--🙈', 64, 5, 'text');
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($file),
'extensions' => 'txt',
'is_image_file' => FALSE,
];
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has only been transliterated.
$this->assertSession()->responseContains('File name is S Pace--tab# #---.txt.');
// Leave transliteration on and enable whitespace replacement.
$this->drupalLogin($admin);
$options['filename_sanitization[replace_whitespace]'] = TRUE;
$this->drupalGet('admin/config/media/file-system');
$this->submitForm($options, 'Save configuration');
$this->drupalLogin($this->account);
// Try again with the monster filename.
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has been transliterated and whitespace replaced.
$this->assertSession()->responseContains('File name is S--Pace--tab#-#---.txt.');
// Leave transliteration and whitespace replacement on, replace non-alpha.
$this->drupalLogin($admin);
$options['filename_sanitization[replace_non_alphanumeric]'] = TRUE;
$options['filename_sanitization[replacement_character]'] = '_';
$this->drupalGet('admin/config/media/file-system');
$this->submitForm($options, 'Save configuration');
$this->drupalLogin($this->account);
// Try again with the monster filename.
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has been transliterated, whitespace replaced with
// '_', and non-alphanumeric characters replaced with '_'.
$this->assertSession()->responseContains('File name is S__Pace--tab___--_.txt.');
// Now turn on the setting to remove duplicate separators.
$this->drupalLogin($admin);
$options['filename_sanitization[deduplicate_separators]'] = TRUE;
$options['filename_sanitization[replacement_character]'] = '-';
$this->drupalGet('admin/config/media/file-system');
$this->submitForm($options, 'Save configuration');
$this->drupalLogin($this->account);
// Try again with the monster filename.
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Test that the file name has been transliterated, whitespace replaced,
// non-alphanumeric characters replaced, and duplicate separators removed.
$this->assertSession()->responseContains('File name is S-Pace-tab.txt.');
// Finally, check the lowercase setting.
$this->drupalLogin($admin);
$options['filename_sanitization[lowercase]'] = TRUE;
$this->drupalGet('admin/config/media/file-system');
$this->submitForm($options, 'Save configuration');
$this->drupalLogin($this->account);
// Generate another file since we're going to start getting collisions with
// previously uploaded and renamed copies.
$file = $this->generateFile('S Pácê--táb# #--🙈-2', 64, 5, 'text');
$edit = [
'files[file_test_upload]' => \Drupal::service('file_system')->realpath($file),
'extensions' => 'txt',
'is_image_file' => FALSE,
];
$this->drupalGet('file-test/upload');
$this->submitForm($edit, 'Submit');
$this->assertSession()->statusCodeEquals(200);
// Make sure all the sanitization options work as intended.
$this->assertSession()->responseContains('File name is s-pace-tab-2.txt.');
// Make sure we got a message about the rename.
$message = 'Your upload has been renamed to <em class="placeholder">s-pace-tab-2.txt</em>';
$this->assertSession()->responseContains($message);
}
}
|