summaryrefslogtreecommitdiffstatshomepage
path: root/core/modules/announcements_feed
diff options
context:
space:
mode:
authorcatch <catch@35733.no-reply.drupal.org>2024-06-19 13:45:54 +0100
committercatch <catch@35733.no-reply.drupal.org>2024-06-19 13:45:54 +0100
commita9f3d0ec7eb7680b4b52c466c3e0868663bb77ab (patch)
tree960b957b08dd04e418275a307673cef262c09bc6 /core/modules/announcements_feed
parente2d8242830e89fd465d88c1f3d81af39a76af02e (diff)
downloaddrupal-a9f3d0ec7eb7680b4b52c466c3e0868663bb77ab.tar.gz
drupal-a9f3d0ec7eb7680b4b52c466c3e0868663bb77ab.zip
Issue #3421418 by mstrelan, Spokje, xjm, mondrake, longwave, acbramley: Add void return typehints to all test methods
Diffstat (limited to 'core/modules/announcements_feed')
-rw-r--r--core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php4
-rw-r--r--core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php4
-rw-r--r--core/modules/announcements_feed/tests/src/Kernel/AnnounceRendererTest.php4
-rw-r--r--core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php2
4 files changed, 7 insertions, 7 deletions
diff --git a/core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php b/core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php
index 189f42f845a..02718fe8e40 100644
--- a/core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php
+++ b/core/modules/announcements_feed/tests/src/FunctionalJavascript/AccessAnnouncementTest.php
@@ -40,7 +40,7 @@ class AccessAnnouncementTest extends OffCanvasTestBase {
/**
* Test of viewing announcements by a user with appropriate permission.
*/
- public function testAnnounceFirstLogin() {
+ public function testAnnounceFirstLogin(): void {
$this->drupalLogin(
$this->drupalCreateUser(
[
@@ -62,7 +62,7 @@ class AccessAnnouncementTest extends OffCanvasTestBase {
/**
* Testing announce icon without announce permission.
*/
- public function testAnnounceWithoutPermission() {
+ public function testAnnounceWithoutPermission(): void {
// User without "access announcements" permission.
$account = $this->drupalCreateUser(
[
diff --git a/core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php b/core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
index 96f3b81b3e1..a4b09d7feae 100644
--- a/core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
+++ b/core/modules/announcements_feed/tests/src/FunctionalJavascript/AlertsJsonFeedTest.php
@@ -56,7 +56,7 @@ class AlertsJsonFeedTest extends OffCanvasTestBase {
/**
* Check the status of the announcements when the feed is updated and removed.
*/
- public function testAnnounceFeedUpdatedAndRemoved() {
+ public function testAnnounceFeedUpdatedAndRemoved(): void {
$this->markTestSkipped('Skipped due to major version-specific logic. See https://www.drupal.org/project/drupal/issues/3359322');
$this->drupalLogin($this->user);
$this->drupalGet('<front>');
@@ -88,7 +88,7 @@ class AlertsJsonFeedTest extends OffCanvasTestBase {
/**
* Check with an empty JSON feed.
*/
- public function testAnnounceFeedEmpty() {
+ public function testAnnounceFeedEmpty(): void {
// Change the feed url and reset temp storage.
AnnounceTestHttpClientMiddleware::setAnnounceTestEndpoint('/announce-feed-json/empty');
diff --git a/core/modules/announcements_feed/tests/src/Kernel/AnnounceRendererTest.php b/core/modules/announcements_feed/tests/src/Kernel/AnnounceRendererTest.php
index d91eebca43d..0c02a77fbe4 100644
--- a/core/modules/announcements_feed/tests/src/Kernel/AnnounceRendererTest.php
+++ b/core/modules/announcements_feed/tests/src/Kernel/AnnounceRendererTest.php
@@ -16,7 +16,7 @@ class AnnounceRendererTest extends AnnounceTestBase {
/**
* Tests rendered valid when something goes wrong.
*/
- public function testRendererException() {
+ public function testRendererException(): void {
$this->setTestFeedResponses([
new Response(403),
]);
@@ -28,7 +28,7 @@ class AnnounceRendererTest extends AnnounceTestBase {
/**
* Tests rendered valid content.
*/
- public function testRendererContent() {
+ public function testRendererContent(): void {
$feed_item_1 = [
'id' => '1001',
'content_html' => 'Test teaser 1',
diff --git a/core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php b/core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php
index f919d86c1cf..a5f98b7cc39 100644
--- a/core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php
+++ b/core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php
@@ -50,7 +50,7 @@ class AnnounceFetcherUnitTest extends UnitTestCase {
*
* @dataProvider urlProvider
*/
- public function testValidateUrl($url, $isValid) {
+ public function testValidateUrl($url, $isValid): void {
$this->assertEquals($isValid, $this->fetcher->validateUrl($url));
}