summaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorDries Buytaert <dries@buytaert.net>2011-10-09 20:52:35 -0400
committerDries Buytaert <dries@buytaert.net>2011-10-09 20:52:35 -0400
commit226a01e280a50c197fbdeab00909fe5856691798 (patch)
tree16c8de2e9c9fa4ff42c21bb6022fc32bbbdaadd0
parent8df7795d565f119bb805d5091d2fc60c4c1aeb76 (diff)
downloaddrupal-226a01e280a50c197fbdeab00909fe5856691798.tar.gz
drupal-226a01e280a50c197fbdeab00909fe5856691798.zip
- Patch #1268234 by derjochenmeyer: move out rendering image from aggregator parser.
-rw-r--r--modules/aggregator/aggregator.pages.inc9
-rw-r--r--modules/aggregator/aggregator.parser.inc13
2 files changed, 11 insertions, 11 deletions
diff --git a/modules/aggregator/aggregator.pages.inc b/modules/aggregator/aggregator.pages.inc
index 3ca084af005..228953b7a58 100644
--- a/modules/aggregator/aggregator.pages.inc
+++ b/modules/aggregator/aggregator.pages.inc
@@ -507,7 +507,14 @@ function template_preprocess_aggregator_feed_source(&$variables) {
$feed = $variables['feed'];
$variables['source_icon'] = theme('feed_icon', array('url' => $feed->url, 'title' => t('!title feed', array('!title' => $feed->title))));
- $variables['source_image'] = $feed->image;
+
+ if (!empty($feed->image) && !empty($feed->title) && !empty($feed->link)) {
+ $variables['source_image'] = l(theme('image', array('path' => $feed->image, 'alt' => $feed->title)), $feed->link, array('html' => TRUE, 'attributes' => array('class' => 'feed-image')));
+ }
+ else {
+ $variables['source_image'] = '';
+ }
+
$variables['source_description'] = aggregator_filter_xss($feed->description);
$variables['source_url'] = check_url(url($feed->link, array('absolute' => TRUE)));
diff --git a/modules/aggregator/aggregator.parser.inc b/modules/aggregator/aggregator.parser.inc
index 98157783597..556f3d3bd80 100644
--- a/modules/aggregator/aggregator.parser.inc
+++ b/modules/aggregator/aggregator.parser.inc
@@ -35,19 +35,12 @@ function aggregator_aggregator_parse($feed) {
$image[$key] = trim($value);
}
- if (!empty($image['link']) && !empty($image['url']) && !empty($image['title'])) {
- $image = l(theme('image', array('path' => $image['url'], 'alt' => $image['title'])), $image['link'], array('html' => TRUE));
- }
- else {
- $image = '';
- }
-
$etag = empty($feed->http_headers['etag']) ? '' : $feed->http_headers['etag'];
// Add parsed data to the feed object.
- $feed->link = !empty($channel['LINK']) ? $channel['LINK'] : '';
- $feed->description = !empty($channel['DESCRIPTION']) ? $channel['DESCRIPTION'] : '';
- $feed->image = $image;
+ $feed->link = !empty($channel['link']) ? $channel['link'] : '';
+ $feed->description = !empty($channel['description']) ? $channel['description'] : '';
+ $feed->image = !empty($image['url']) ? $image['url'] : '';
$feed->etag = $etag;
$feed->modified = $modified;