diff options
author | Eric Snow <ericsnowcurrently@gmail.com> | 2023-03-14 10:05:54 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-14 10:05:54 -0600 |
commit | 1ff81c0cb67215694f084e51c4d35ae53b9f5cf9 (patch) | |
tree | e8067aff7f52f7b17284caa3452b17a98a9ae1bc /Tools/c-analyzer/c_parser/preprocessor/common.py | |
parent | a703f743dbf2675948e59c44fa9d7112f7825100 (diff) | |
download | cpython-1ff81c0cb67215694f084e51c4d35ae53b9f5cf9.tar.gz cpython-1ff81c0cb67215694f084e51c4d35ae53b9f5cf9.zip |
gh-81057: Add a CI Check for New Unsupported C Global Variables (gh-102506)
This will keep us from adding new unsupported (i.e. non-const) C global variables, which would break interpreter isolation.
FYI, historically it is very uncommon for new global variables to get added. Furthermore, it is rare for new code to break the c-analyzer. So the check should almost always pass unnoticed.
Note that I've removed test_check_c_globals. A test wasn't a great fit conceptually and was super slow on debug builds. A CI check is a better fit.
This also resolves gh-100237.
https://github.com/python/cpython/issues/81057
Diffstat (limited to 'Tools/c-analyzer/c_parser/preprocessor/common.py')
-rw-r--r-- | Tools/c-analyzer/c_parser/preprocessor/common.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Tools/c-analyzer/c_parser/preprocessor/common.py b/Tools/c-analyzer/c_parser/preprocessor/common.py index 4291a066337..dbe1edeef38 100644 --- a/Tools/c-analyzer/c_parser/preprocessor/common.py +++ b/Tools/c-analyzer/c_parser/preprocessor/common.py @@ -115,15 +115,15 @@ def converted_error(tool, argv, filename): def convert_error(tool, argv, filename, stderr, rc): error = (stderr.splitlines()[0], rc) if (_expected := is_os_mismatch(filename, stderr)): - logger.debug(stderr.strip()) + logger.info(stderr.strip()) raise OSMismatchError(filename, _expected, argv, error, tool) elif (_missing := is_missing_dep(stderr)): - logger.debug(stderr.strip()) + logger.info(stderr.strip()) raise MissingDependenciesError(filename, (_missing,), argv, error, tool) elif '#error' in stderr: # XXX Ignore incompatible files. error = (stderr.splitlines()[1], rc) - logger.debug(stderr.strip()) + logger.info(stderr.strip()) raise ErrorDirectiveError(filename, argv, error, tool) else: # Try one more time, with stderr written to the terminal. |