diff options
author | Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> | 2025-02-14 17:16:47 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2025-02-14 18:16:47 +0100 |
commit | 3402e133ef26736296c07992266a82b181a5d532 (patch) | |
tree | ec5c08ef33faa43ffa061e278db688bf1722512e /Python/instruction_sequence.c | |
parent | 6666b38c28856e0fa5dbf14e33cf2eb2c06410a1 (diff) | |
download | cpython-3402e133ef26736296c07992266a82b181a5d532.tar.gz cpython-3402e133ef26736296c07992266a82b181a5d532.zip |
gh-82045: Correct and deduplicate "isprintable" docs; add test. (GH-130118)
We had the definition of what makes a character "printable" documented in three places, giving two different definitions.
The definition in the comment on `_PyUnicode_IsPrintable` was inverted; correct that.
With that correction, the two definitions turn out to be equivalent -- but to confirm that, you have to go look up, or happen to know, that those are the only five "Other" categories and only three "Separator" categories in the Unicode character database. That makes it hard for the reader to tell whether they really are the same, or if there's some subtle difference in the intended semantics.
Fix that by cutting the C API docs' and the C comment's copies of the subtle details, in favor of referring to the Python-level docs. That ensures it's explicit that these are all meant to agree, and also lets us concentrate improvements to the wording in one place.
Speaking of which, borrow some ideas from the C comment, along with other tweaks, to hopefully add a bit more clarity to that one newly-centralized copy in the docs.
Also add a thorough test that the implementation agrees with this definition.
Author: Greg Price <gnprice@gmail.com>
Co-authored-by: Greg Price <gnprice@gmail.com>
Diffstat (limited to 'Python/instruction_sequence.c')
0 files changed, 0 insertions, 0 deletions