aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/Python/executor_cases.c.h
diff options
context:
space:
mode:
authorJelle Zijlstra <jelle.zijlstra@gmail.com>2023-09-08 19:49:20 -0700
committerGitHub <noreply@github.com>2023-09-09 02:49:20 +0000
commit17f994174de9211b2baaff217eeb1033343230fc (patch)
tree9fe4978f48c3adf845313f6c18f1f81c1217eac4 /Python/executor_cases.c.h
parente9e2ca7a7b4b4320009cdf85c84ec5bd6c4923c3 (diff)
downloadcpython-17f994174de9211b2baaff217eeb1033343230fc.tar.gz
cpython-17f994174de9211b2baaff217eeb1033343230fc.zip
gh-109118: Fix runtime crash when NameError happens in PEP 695 function (#109123)
Diffstat (limited to 'Python/executor_cases.c.h')
-rw-r--r--Python/executor_cases.c.h42
1 files changed, 39 insertions, 3 deletions
diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
index fa7cb88e4a1..918991dca7d 100644
--- a/Python/executor_cases.c.h
+++ b/Python/executor_cases.c.h
@@ -1046,7 +1046,7 @@
break;
}
- case _LOAD_LOCALS: {
+ case LOAD_LOCALS: {
PyObject *locals;
locals = LOCALS();
if (locals == NULL) {
@@ -1060,16 +1060,51 @@
break;
}
- case _LOAD_FROM_DICT_OR_GLOBALS: {
+ case LOAD_FROM_DICT_OR_GLOBALS: {
PyObject *mod_or_class_dict;
PyObject *v;
mod_or_class_dict = stack_pointer[-1];
PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
- Py_DECREF(mod_or_class_dict);
goto error;
}
+ if (v == NULL) {
+ v = PyDict_GetItemWithError(GLOBALS(), name);
+ if (v != NULL) {
+ Py_INCREF(v);
+ }
+ else if (_PyErr_Occurred(tstate)) {
+ goto error;
+ }
+ else {
+ if (PyMapping_GetOptionalItem(BUILTINS(), name, &v) < 0) {
+ goto error;
+ }
+ if (v == NULL) {
+ _PyEval_FormatExcCheckArg(
+ tstate, PyExc_NameError,
+ NAME_ERROR_MSG, name);
+ goto error;
+ }
+ }
+ }
Py_DECREF(mod_or_class_dict);
+ stack_pointer[-1] = v;
+ break;
+ }
+
+ case LOAD_NAME: {
+ PyObject *v;
+ PyObject *mod_or_class_dict = LOCALS();
+ if (mod_or_class_dict == NULL) {
+ _PyErr_SetString(tstate, PyExc_SystemError,
+ "no locals found");
+ if (true) goto error;
+ }
+ PyObject *name = GETITEM(FRAME_CO_NAMES, oparg);
+ if (PyMapping_GetOptionalItem(mod_or_class_dict, name, &v) < 0) {
+ goto error;
+ }
if (v == NULL) {
v = PyDict_GetItemWithError(GLOBALS(), name);
if (v != NULL) {
@@ -1090,6 +1125,7 @@
}
}
}
+ STACK_GROW(1);
stack_pointer[-1] = v;
break;
}