aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/Lib
diff options
context:
space:
mode:
authorAugusto Hack <hack.augusto@gmail.com>2019-06-02 23:14:48 -0300
committerEric V. Smith <ericvsmith@users.noreply.github.com>2019-06-02 22:14:48 -0400
commit01ee12ba35a333e8a6a25c4153c4a21838e9585c (patch)
tree2bfae29ffb6dd7c2c3b94e90d6f4c4294b7be3e9 /Lib
parent0025350294959594e7f57aef4fc9579c77a0ed1c (diff)
downloadcpython-01ee12ba35a333e8a6a25c4153c4a21838e9585c.tar.gz
cpython-01ee12ba35a333e8a6a25c4153c4a21838e9585c.zip
bpo-33569 Preserve type information with dataclasses.InitVar (GH-8927)
Diffstat (limited to 'Lib')
-rw-r--r--Lib/dataclasses.py13
-rwxr-xr-xLib/test/test_dataclasses.py6
2 files changed, 16 insertions, 3 deletions
diff --git a/Lib/dataclasses.py b/Lib/dataclasses.py
index 75113f123b3..b035cbb809f 100644
--- a/Lib/dataclasses.py
+++ b/Lib/dataclasses.py
@@ -201,10 +201,16 @@ _MODULE_IDENTIFIER_RE = re.compile(r'^(?:\s*(\w+)\s*\.)?\s*(\w+)')
class _InitVarMeta(type):
def __getitem__(self, params):
- return self
+ return InitVar(params)
class InitVar(metaclass=_InitVarMeta):
- pass
+ __slots__ = ('type', )
+
+ def __init__(self, type):
+ self.type = type
+
+ def __repr__(self):
+ return f'dataclasses.InitVar[{self.type.__name__}]'
# Instances of Field are only ever created from within this module,
@@ -586,7 +592,8 @@ def _is_classvar(a_type, typing):
def _is_initvar(a_type, dataclasses):
# The module we're checking against is the module we're
# currently in (dataclasses.py).
- return a_type is dataclasses.InitVar
+ return (a_type is dataclasses.InitVar
+ or type(a_type) is dataclasses.InitVar)
def _is_type(annotation, cls, a_module, a_type, is_type_predicate):
diff --git a/Lib/test/test_dataclasses.py b/Lib/test/test_dataclasses.py
index 867210688f5..53e8443c2ad 100755
--- a/Lib/test/test_dataclasses.py
+++ b/Lib/test/test_dataclasses.py
@@ -1097,6 +1097,12 @@ class TestCase(unittest.TestCase):
c = C(init_param=10)
self.assertEqual(c.x, 20)
+ def test_init_var_preserve_type(self):
+ self.assertEqual(InitVar[int].type, int)
+
+ # Make sure the repr is correct.
+ self.assertEqual(repr(InitVar[int]), 'dataclasses.InitVar[int]')
+
def test_init_var_inheritance(self):
# Note that this deliberately tests that a dataclass need not
# have a __post_init__ function if it has an InitVar field.