diff options
author | Chris Withers <chris@withers.org> | 2019-05-01 23:04:04 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-05-01 23:04:04 +0100 |
commit | adbf178e49113b2de0042e86a1228560475a65c5 (patch) | |
tree | 871ac21aec993e310f915cf2781909282a7a03e9 /Lib/unittest/test/testmock/testwith.py | |
parent | b7378d77289c911ca6a0c0afaf513879002df7d5 (diff) | |
download | cpython-adbf178e49113b2de0042e86a1228560475a65c5.tar.gz cpython-adbf178e49113b2de0042e86a1228560475a65c5.zip |
Mock 100% coverage (GH-13045)
This was achieved by:
* moving many pass statements in tests onto their own lines, so they pass line coverage and can match an easy ignore pattern if branch coverage is added later.
* removing code that cannot be reached.
* removing long-disabled tests.
* removing unused code.
* adding tests for uncovered code
It turned out that removing `if __name__ == '__main__'` blocks that run unittest.main() at the bottom of test files was surprisingly contentious, so they remain and can be filtered out with an appropriate .coveragerc.
Diffstat (limited to 'Lib/unittest/test/testmock/testwith.py')
-rw-r--r-- | Lib/unittest/test/testmock/testwith.py | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/Lib/unittest/test/testmock/testwith.py b/Lib/unittest/test/testmock/testwith.py index ec4e540dcfd..37100b8c183 100644 --- a/Lib/unittest/test/testmock/testwith.py +++ b/Lib/unittest/test/testmock/testwith.py @@ -10,6 +10,8 @@ something = sentinel.Something something_else = sentinel.SomethingElse +class SampleException(Exception): pass + class WithTest(unittest.TestCase): @@ -20,14 +22,10 @@ class WithTest(unittest.TestCase): def test_with_statement_exception(self): - try: + with self.assertRaises(SampleException): with patch('%s.something' % __name__, sentinel.Something2): self.assertEqual(something, sentinel.Something2, "unpatched") - raise Exception('pow') - except Exception: - pass - else: - self.fail("patch swallowed exception") + raise SampleException() self.assertEqual(something, sentinel.Something) @@ -128,8 +126,7 @@ class WithTest(unittest.TestCase): def test_double_patch_instance_method(self): class C: - def f(self): - pass + def f(self): pass c = C() |