aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/Lib/test/test_asyncio/test_tasks.py
diff options
context:
space:
mode:
authorAndrew Svetlov <andrew.svetlov@gmail.com>2022-03-17 22:51:40 +0200
committerGitHub <noreply@github.com>2022-03-17 22:51:40 +0200
commit903f0a02c16240dc769a08c30e8d072a4fb09154 (patch)
tree00a9ff2477f94c7067c9daad481abde0d8d8ff3b /Lib/test/test_asyncio/test_tasks.py
parent33698e8ff40fcc67df3d95658e87196f8021de6f (diff)
downloadcpython-903f0a02c16240dc769a08c30e8d072a4fb09154.tar.gz
cpython-903f0a02c16240dc769a08c30e8d072a4fb09154.zip
bpo-34790: Remove passing coroutine objects to asyncio.wait() (GH-31964)
Co-authored-by: Yury Selivanov <yury@edgedb.com>
Diffstat (limited to 'Lib/test/test_asyncio/test_tasks.py')
-rw-r--r--Lib/test/test_asyncio/test_tasks.py55
1 files changed, 7 insertions, 48 deletions
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
index 141c019dcb9..b86646ee398 100644
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -997,13 +997,12 @@ class BaseTaskTests:
async def coro(s):
return s
- c = coro('test')
+ c = self.loop.create_task(coro('test'))
task = self.new_task(
self.loop,
- asyncio.wait([c, c, coro('spam')]))
+ asyncio.wait([c, c, self.loop.create_task(coro('spam'))]))
- with self.assertWarns(DeprecationWarning):
- done, pending = self.loop.run_until_complete(task)
+ done, pending = self.loop.run_until_complete(task)
self.assertFalse(pending)
self.assertEqual(set(f.result() for f in done), {'test', 'spam'})
@@ -1380,11 +1379,9 @@ class BaseTaskTests:
async def test():
futs = list(asyncio.as_completed(fs))
self.assertEqual(len(futs), 2)
- waiter = asyncio.wait(futs)
- # Deprecation from passing coros in futs to asyncio.wait()
- with self.assertWarns(DeprecationWarning) as cm:
- done, pending = await waiter
- self.assertEqual(cm.warnings[0].filename, __file__)
+ done, pending = await asyncio.wait(
+ [asyncio.ensure_future(fut) for fut in futs]
+ )
self.assertEqual(set(f.result() for f in done), {'a', 'b'})
loop = self.new_test_loop(gen)
@@ -1434,21 +1431,6 @@ class BaseTaskTests:
loop.run_until_complete(test())
- def test_as_completed_coroutine_use_global_loop(self):
- # Deprecated in 3.10
- async def coro():
- return 42
-
- loop = self.new_test_loop()
- asyncio.set_event_loop(loop)
- self.addCleanup(asyncio.set_event_loop, None)
- futs = asyncio.as_completed([coro()])
- with self.assertWarns(DeprecationWarning) as cm:
- futs = list(futs)
- self.assertEqual(cm.warnings[0].filename, __file__)
- self.assertEqual(len(futs), 1)
- self.assertEqual(loop.run_until_complete(futs[0]), 42)
-
def test_sleep(self):
def gen():
@@ -1751,7 +1733,7 @@ class BaseTaskTests:
async def outer():
nonlocal proof
with self.assertWarns(DeprecationWarning):
- d, p = await asyncio.wait([inner()])
+ d, p = await asyncio.wait([asyncio.create_task(inner())])
proof += 100
f = asyncio.ensure_future(outer(), loop=self.loop)
@@ -3220,29 +3202,6 @@ class SleepTests(test_utils.TestCase):
self.assertEqual(result, 11)
-class WaitTests(test_utils.TestCase):
- def setUp(self):
- super().setUp()
- self.loop = asyncio.new_event_loop()
- self.set_event_loop(self.loop)
-
- def tearDown(self):
- self.loop.close()
- self.loop = None
- super().tearDown()
-
- def test_coro_is_deprecated_in_wait(self):
- # Remove test when passing coros to asyncio.wait() is removed in 3.11
- with self.assertWarns(DeprecationWarning):
- self.loop.run_until_complete(
- asyncio.wait([coroutine_function()]))
-
- task = self.loop.create_task(coroutine_function())
- with self.assertWarns(DeprecationWarning):
- self.loop.run_until_complete(
- asyncio.wait([task, coroutine_function()]))
-
-
class CompatibilityTests(test_utils.TestCase):
# Tests for checking a bridge between old-styled coroutines
# and async/await syntax