diff options
| author | Victor Stinner <victor.stinner@gmail.com> | 2017-09-01 14:46:06 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-09-01 14:46:06 +0200 |
| commit | 16432beadb8eba079c9786cc0c0eaacfd9fd2f7b (patch) | |
| tree | f3c14222ddf24a83d355f6dbf1786ab65ed15600 /Lib/test/test_asyncio/test_futures.py | |
| parent | 6c2feabc5dac2f3049b15134669e9ad5af573193 (diff) | |
| download | cpython-16432beadb8eba079c9786cc0c0eaacfd9fd2f7b.tar.gz cpython-16432beadb8eba079c9786cc0c0eaacfd9fd2f7b.zip | |
bpo-31250, test_asyncio: fix dangling threads (#3252)
* Explicitly call shutdown(wait=True) on executors to wait until all
threads complete to prevent side effects between tests.
* Fix test_loop_self_reading_exception(): don't mock loop.close().
Previously, the original close() method was called rather than the
mock, because how set_event_loop() registered loop.close().
Diffstat (limited to 'Lib/test/test_asyncio/test_futures.py')
| -rw-r--r-- | Lib/test/test_asyncio/test_futures.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/Lib/test/test_asyncio/test_futures.py b/Lib/test/test_asyncio/test_futures.py index ebedfec7fa3..f8f614f1c30 100644 --- a/Lib/test/test_asyncio/test_futures.py +++ b/Lib/test/test_asyncio/test_futures.py @@ -380,6 +380,7 @@ class BaseFutureTests: self.assertTrue(asyncio.isfuture(f2)) self.assertEqual(res, 'oi') self.assertNotEqual(ident, threading.get_ident()) + ex.shutdown(wait=True) def test_wrap_future_future(self): f1 = self._new_future(loop=self.loop) @@ -395,6 +396,7 @@ class BaseFutureTests: f1 = ex.submit(run, 'oi') f2 = asyncio.wrap_future(f1) self.assertIs(self.loop, f2._loop) + ex.shutdown(wait=True) def test_wrap_future_cancel(self): f1 = concurrent.futures.Future() |