aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/Lib/test/test_asyncio/test_futures.py
diff options
context:
space:
mode:
authorAndrew Svetlov <andrew.svetlov@gmail.com>2022-03-23 17:43:05 +0200
committerGitHub <noreply@github.com>2022-03-23 08:43:05 -0700
commit0360e9f34659e7d7f3dae021b82f78452db8c714 (patch)
treef88f12dd56fb3f0cca5557447835c94fbea12cb5 /Lib/test/test_asyncio/test_futures.py
parent624e3986fbf8467772e4863b7ec004e65adff619 (diff)
downloadcpython-0360e9f34659e7d7f3dae021b82f78452db8c714.tar.gz
cpython-0360e9f34659e7d7f3dae021b82f78452db8c714.zip
bpo-46829: Deprecate passing a message into Future.cancel() and Task.cancel() (GH-31840)
After a long deliberation we ended up feeling that the message argument for Future.cancel(), added in 3.9, was a bad idea, so we're deprecating it in 3.11 and plan to remove it in 3.13.
Diffstat (limited to 'Lib/test/test_asyncio/test_futures.py')
-rw-r--r--Lib/test/test_asyncio/test_futures.py12
1 files changed, 10 insertions, 2 deletions
diff --git a/Lib/test/test_asyncio/test_futures.py b/Lib/test/test_asyncio/test_futures.py
index 84d7d45af94..cf677f6a951 100644
--- a/Lib/test/test_asyncio/test_futures.py
+++ b/Lib/test/test_asyncio/test_futures.py
@@ -228,14 +228,22 @@ class BaseFutureTests:
self.assertTrue(hasattr(f, '_cancel_message'))
self.assertEqual(f._cancel_message, None)
- f.cancel('my message')
+ with self.assertWarnsRegex(
+ DeprecationWarning,
+ "Passing 'msg' argument"
+ ):
+ f.cancel('my message')
with self.assertRaises(asyncio.CancelledError):
self.loop.run_until_complete(f)
self.assertEqual(f._cancel_message, 'my message')
def test_future_cancel_message_setter(self):
f = self._new_future(loop=self.loop)
- f.cancel('my message')
+ with self.assertWarnsRegex(
+ DeprecationWarning,
+ "Passing 'msg' argument"
+ ):
+ f.cancel('my message')
f._cancel_message = 'my new message'
self.assertEqual(f._cancel_message, 'my new message')