diff options
| author | Serhiy Storchaka <storchaka@gmail.com> | 2023-10-30 19:18:36 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-30 19:18:36 +0200 |
| commit | 624ace5a2f02715d084c29eaf2211cd0dd550690 (patch) | |
| tree | f40e40a955de034d9e6ad90cf162fc0509fa1480 /Lib/test/_test_multiprocessing.py | |
| parent | 55df2deb1aeb182f30026bde5e8b5ea575a2dab8 (diff) | |
| download | cpython-624ace5a2f02715d084c29eaf2211cd0dd550690.tar.gz cpython-624ace5a2f02715d084c29eaf2211cd0dd550690.zip | |
gh-111284: Make multiprocessing tests with threads faster and more reliable (GH-111285)
Diffstat (limited to 'Lib/test/_test_multiprocessing.py')
| -rw-r--r-- | Lib/test/_test_multiprocessing.py | 30 |
1 files changed, 21 insertions, 9 deletions
diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py index 0b333ca3b7e..bf87a3e8d6f 100644 --- a/Lib/test/_test_multiprocessing.py +++ b/Lib/test/_test_multiprocessing.py @@ -2438,8 +2438,11 @@ class _TestContainers(BaseTestCase): # # -def sqr(x, wait=0.0): - time.sleep(wait) +def sqr(x, wait=0.0, event=None): + if event is None: + time.sleep(wait) + else: + event.wait(wait) return x*x def mul(x, y): @@ -2578,10 +2581,18 @@ class _TestPool(BaseTestCase): self.assertTimingAlmostEqual(get.elapsed, TIMEOUT1) def test_async_timeout(self): - res = self.pool.apply_async(sqr, (6, TIMEOUT2 + support.SHORT_TIMEOUT)) - get = TimingWrapper(res.get) - self.assertRaises(multiprocessing.TimeoutError, get, timeout=TIMEOUT2) - self.assertTimingAlmostEqual(get.elapsed, TIMEOUT2) + p = self.Pool(3) + try: + event = threading.Event() if self.TYPE == 'threads' else None + res = p.apply_async(sqr, (6, TIMEOUT2 + support.SHORT_TIMEOUT, event)) + get = TimingWrapper(res.get) + self.assertRaises(multiprocessing.TimeoutError, get, timeout=TIMEOUT2) + self.assertTimingAlmostEqual(get.elapsed, TIMEOUT2) + finally: + if event is not None: + event.set() + p.terminate() + p.join() def test_imap(self): it = self.pool.imap(sqr, list(range(10))) @@ -2683,10 +2694,11 @@ class _TestPool(BaseTestCase): def test_terminate(self): # Simulate slow tasks which take "forever" to complete + p = self.Pool(3) args = [support.LONG_TIMEOUT for i in range(10_000)] - result = self.pool.map_async(time.sleep, args, chunksize=1) - self.pool.terminate() - self.pool.join() + result = p.map_async(time.sleep, args, chunksize=1) + p.terminate() + p.join() def test_empty_iterable(self): # See Issue 12157 |