diff options
| author | Michal Čihař <michal@cihar.com> | 2020-11-10 17:06:02 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-10 08:06:02 -0800 |
| commit | e59b2deffde61e5641cabd65034fa11b4db898ba (patch) | |
| tree | c8f4405fcd90bbd902797987f817277fc4f8c92b | |
| parent | 3eb284622579d04289d0e3b2e97fbf56df6e845e (diff) | |
| download | cpython-e59b2deffde61e5641cabd65034fa11b4db898ba.tar.gz cpython-e59b2deffde61e5641cabd65034fa11b4db898ba.zip | |
bpo-42014: shutil.rmtree: call onerror with correct function (GH-22585)
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open.
Not sure if this needs bug or not...
Automerge-Triggered-By: GH:hynek
| -rw-r--r-- | Lib/shutil.py | 2 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/Library/2020-11-10-15-40-56.bpo-42014.ShM37l.rst | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/Lib/shutil.py b/Lib/shutil.py index 223e9a8a705..f0e833dc979 100644 --- a/Lib/shutil.py +++ b/Lib/shutil.py @@ -711,7 +711,7 @@ def rmtree(path, ignore_errors=False, onerror=None): try: fd = os.open(path, os.O_RDONLY) except Exception: - onerror(os.lstat, path, sys.exc_info()) + onerror(os.open, path, sys.exc_info()) return try: if os.path.samestat(orig_st, os.fstat(fd)): diff --git a/Misc/NEWS.d/next/Library/2020-11-10-15-40-56.bpo-42014.ShM37l.rst b/Misc/NEWS.d/next/Library/2020-11-10-15-40-56.bpo-42014.ShM37l.rst new file mode 100644 index 00000000000..d3e1abcd84c --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-11-10-15-40-56.bpo-42014.ShM37l.rst @@ -0,0 +1 @@ +The ``onerror`` callback from ``shutil.rmtree`` now receives correct function when ``os.open`` fails.
\ No newline at end of file |