From 7d15225ad0f722e1ce42f4030a48ecd41636eea4 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 23 Sep 2020 00:25:47 +0000 Subject: Users: Check if the user ID passed as `selected` to `wp_dropdown_users()` corresponds to an existing user. This avoids a few PHP notices if the `include_selected` parameter was specified and a non-existing user ID was passed. Props campusboy1987. Fixes #51370. git-svn-id: https://develop.svn.wordpress.org/trunk@49036 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/user/wpDropdownUsers.php | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'tests/phpunit') diff --git a/tests/phpunit/tests/user/wpDropdownUsers.php b/tests/phpunit/tests/user/wpDropdownUsers.php index 4f6b89db77..91c35cf63a 100644 --- a/tests/phpunit/tests/user/wpDropdownUsers.php +++ b/tests/phpunit/tests/user/wpDropdownUsers.php @@ -129,6 +129,22 @@ class Tests_User_WpDropdownUsers extends WP_UnitTestCase { $this->assertContains( $user1->user_login, $found ); } + /** + * @ticket 51370 + */ + public function test_include_selected_with_non_existing_user_id() { + $found = wp_dropdown_users( + array( + 'echo' => false, + 'selected' => PHP_INT_MAX, + 'include_selected' => true, + 'show' => 'user_login', + ) + ); + + $this->assertNotContains( (string) PHP_INT_MAX, $found ); + } + /** * @ticket 38135 */ -- cgit v1.2.3