From 7f9d1d6ab923096582622b700bedb6a571518eac Mon Sep 17 00:00:00 2001 From: Damien George Date: Thu, 9 Apr 2015 23:56:15 +0100 Subject: py: Overhaul and simplify printf/pfenv mechanism. Previous to this patch the printing mechanism was a bit of a tangled mess. This patch attempts to consolidate printing into one interface. All (non-debug) printing now uses the mp_print* family of functions, mainly mp_printf. All these functions take an mp_print_t structure as their first argument, and this structure defines the printing backend through the "print_strn" function of said structure. Printing from the uPy core can reach the platform-defined print code via two paths: either through mp_sys_stdout_obj (defined pert port) in conjunction with mp_stream_write; or through the mp_plat_print structure which uses the MP_PLAT_PRINT_STRN macro to define how string are printed on the platform. The former is only used when MICROPY_PY_IO is defined. With this new scheme printing is generally more efficient (less layers to go through, less arguments to pass), and, given an mp_print_t* structure, one can call mp_print_str for efficiency instead of mp_printf("%s", ...). Code size is also reduced by around 200 bytes on Thumb2 archs. --- py/objcell.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'py/objcell.c') diff --git a/py/objcell.c b/py/objcell.c index 9adbc16aea..97f1ecd63c 100644 --- a/py/objcell.c +++ b/py/objcell.c @@ -42,16 +42,16 @@ void mp_obj_cell_set(mp_obj_t self_in, mp_obj_t obj) { } #if MICROPY_ERROR_REPORTING == MICROPY_ERROR_REPORTING_DETAILED -STATIC void cell_print(void (*print)(void *env, const char *fmt, ...), void *env, mp_obj_t o_in, mp_print_kind_t kind) { +STATIC void cell_print(const mp_print_t *print, mp_obj_t o_in, mp_print_kind_t kind) { (void)kind; mp_obj_cell_t *o = o_in; - print(env, "obj); + mp_printf(print, "obj); if (o->obj == MP_OBJ_NULL) { - print(env, "(nil)"); + mp_print_str(print, "(nil)"); } else { - mp_obj_print_helper(print, env, o->obj, PRINT_REPR); + mp_obj_print_helper(print, o->obj, PRINT_REPR); } - print(env, ">"); + mp_print_str(print, ">"); } #endif -- cgit v1.2.3