diff options
author | Damien George <damien.p.george@gmail.com> | 2014-05-10 13:55:11 +0100 |
---|---|---|
committer | Damien George <damien.p.george@gmail.com> | 2014-05-10 13:55:11 +0100 |
commit | d0a5bf34f746276550aef9c8519160c033611571 (patch) | |
tree | 2c24601b11eeb11f161082a92b89eb559702cc4e /py/objset.c | |
parent | 2bb179e1248f045525b247981e3e5285800b63d6 (diff) | |
download | micropython-d0a5bf34f746276550aef9c8519160c033611571.tar.gz micropython-d0a5bf34f746276550aef9c8519160c033611571.zip |
py: Tidy up returning NULL which should be MP_OBJ_NOT_SUPPORTED.
Diffstat (limited to 'py/objset.c')
-rw-r--r-- | py/objset.c | 68 |
1 files changed, 33 insertions, 35 deletions
diff --git a/py/objset.c b/py/objset.c index 8b1be26857..3e56fd79ef 100644 --- a/py/objset.c +++ b/py/objset.c @@ -412,41 +412,39 @@ STATIC mp_obj_t set_unary_op(int op, mp_obj_t self_in) { STATIC mp_obj_t set_binary_op(int op, mp_obj_t lhs, mp_obj_t rhs) { mp_obj_t args[] = {lhs, rhs}; switch (op) { - case MP_BINARY_OP_OR: - return set_union(lhs, rhs); - case MP_BINARY_OP_XOR: - return set_symmetric_difference(lhs, rhs); - case MP_BINARY_OP_AND: - return set_intersect(lhs, rhs); - case MP_BINARY_OP_SUBTRACT: - return set_diff(2, args); - case MP_BINARY_OP_INPLACE_OR: - return set_union(lhs, rhs); - case MP_BINARY_OP_INPLACE_XOR: - return set_symmetric_difference(lhs, rhs); - case MP_BINARY_OP_INPLACE_AND: - return set_intersect(lhs, rhs); - case MP_BINARY_OP_INPLACE_SUBTRACT: - return set_diff(2, args); - case MP_BINARY_OP_LESS: - return set_issubset_proper(lhs, rhs); - case MP_BINARY_OP_MORE: - return set_issuperset_proper(lhs, rhs); - case MP_BINARY_OP_EQUAL: - return set_equal(lhs, rhs); - case MP_BINARY_OP_LESS_EQUAL: - return set_issubset(lhs, rhs); - case MP_BINARY_OP_MORE_EQUAL: - return set_issuperset(lhs, rhs); - case MP_BINARY_OP_IN: - { - mp_obj_set_t *o = lhs; - mp_obj_t elem = mp_set_lookup(&o->set, rhs, MP_MAP_LOOKUP); - return MP_BOOL(elem != NULL); - } - default: - // op not supported - return NULL; + case MP_BINARY_OP_OR: + return set_union(lhs, rhs); + case MP_BINARY_OP_XOR: + return set_symmetric_difference(lhs, rhs); + case MP_BINARY_OP_AND: + return set_intersect(lhs, rhs); + case MP_BINARY_OP_SUBTRACT: + return set_diff(2, args); + case MP_BINARY_OP_INPLACE_OR: + return set_union(lhs, rhs); + case MP_BINARY_OP_INPLACE_XOR: + return set_symmetric_difference(lhs, rhs); + case MP_BINARY_OP_INPLACE_AND: + return set_intersect(lhs, rhs); + case MP_BINARY_OP_INPLACE_SUBTRACT: + return set_diff(2, args); + case MP_BINARY_OP_LESS: + return set_issubset_proper(lhs, rhs); + case MP_BINARY_OP_MORE: + return set_issuperset_proper(lhs, rhs); + case MP_BINARY_OP_EQUAL: + return set_equal(lhs, rhs); + case MP_BINARY_OP_LESS_EQUAL: + return set_issubset(lhs, rhs); + case MP_BINARY_OP_MORE_EQUAL: + return set_issuperset(lhs, rhs); + case MP_BINARY_OP_IN: { + mp_obj_set_t *o = lhs; + mp_obj_t elem = mp_set_lookup(&o->set, rhs, MP_MAP_LOOKUP); + return MP_BOOL(elem != NULL); + } + default: + return MP_OBJ_NOT_SUPPORTED; } } |