diff options
| author | Damien George <damien.p.george@gmail.com> | 2015-04-01 14:10:50 +0000 |
|---|---|---|
| committer | Damien George <damien.p.george@gmail.com> | 2015-04-11 16:54:37 +0100 |
| commit | b1bbe966c408901ae64ea8c8b468694c47d05b1a (patch) | |
| tree | 46025c34daf602aeb1e8def41d1e01f0750b6d13 /py/objrange.c | |
| parent | d07ccc5a394d0252ffbc227509ed2134465c215a (diff) | |
| download | micropython-b1bbe966c408901ae64ea8c8b468694c47d05b1a.tar.gz micropython-b1bbe966c408901ae64ea8c8b468694c47d05b1a.zip | |
py: Combine load_attr and store_attr type methods into one (attr).
This simplifies the API for objects and reduces code size (by around 400
bytes on Thumb2, and around 2k on x86). Performance impact was measured
with Pystone score, but change was barely noticeable.
Diffstat (limited to 'py/objrange.c')
| -rw-r--r-- | py/objrange.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/py/objrange.c b/py/objrange.c index ff62cc5b81..9f7e6591e1 100644 --- a/py/objrange.c +++ b/py/objrange.c @@ -168,7 +168,11 @@ STATIC mp_obj_t range_getiter(mp_obj_t o_in) { #if MICROPY_PY_BUILTINS_RANGE_ATTRS -STATIC void range_load_attr(mp_obj_t o_in, qstr attr, mp_obj_t *dest) { +STATIC void range_attr(mp_obj_t o_in, qstr attr, mp_obj_t *dest) { + if (dest[0] != MP_OBJ_NULL) { + // not load attribute + return; + } mp_obj_range_t *o = o_in; if (attr == MP_QSTR_start) { dest[0] = mp_obj_new_int(o->start); @@ -189,6 +193,6 @@ const mp_obj_type_t mp_type_range = { .subscr = range_subscr, .getiter = range_getiter, #if MICROPY_PY_BUILTINS_RANGE_ATTRS - .load_attr = range_load_attr, + .attr = range_attr, #endif }; |