diff options
| author | Damien George <damien.p.george@gmail.com> | 2015-12-08 12:28:11 +0000 |
|---|---|---|
| committer | Damien George <damien.p.george@gmail.com> | 2015-12-10 22:19:48 +0000 |
| commit | bdbe8c9ae21559f6dc0b8e1ad84b7bbec2a04726 (patch) | |
| tree | 3c603ca42bd10e7d5bbd037d85d6b57735d39393 /py/objbool.c | |
| parent | e242b1785f9e25b36f5d225652c679cd7cec6ec0 (diff) | |
| download | micropython-bdbe8c9ae21559f6dc0b8e1ad84b7bbec2a04726.tar.gz micropython-bdbe8c9ae21559f6dc0b8e1ad84b7bbec2a04726.zip | |
py: Make UNARY_OP_NOT a first-class op, to agree with Py not semantics.
Fixes #1684 and makes "not" match Python semantics. The code is also
simplified (the separate MP_BC_NOT opcode is removed) and the patch saves
68 bytes for bare-arm/ and 52 bytes for minimal/.
Previously "not x" was implemented as !mp_unary_op(x, MP_UNARY_OP_BOOL),
so any given object only needs to implement MP_UNARY_OP_BOOL (and the VM
had a special opcode to do the ! bit).
With this patch "not x" is implemented as mp_unary_op(x, MP_UNARY_OP_NOT),
but this operation is caught at the start of mp_unary_op and dispatched as
!mp_obj_is_true(x). mp_obj_is_true has special logic to test for
truthness, and is the correct way to handle the not operation.
Diffstat (limited to 'py/objbool.c')
| -rw-r--r-- | py/objbool.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/py/objbool.c b/py/objbool.c index 622005657a..4276335635 100644 --- a/py/objbool.c +++ b/py/objbool.c @@ -74,15 +74,6 @@ STATIC mp_obj_t bool_unary_op(mp_uint_t op, mp_obj_t o_in) { case MP_UNARY_OP_POSITIVE: return MP_OBJ_NEW_SMALL_INT(value); case MP_UNARY_OP_NEGATIVE: return MP_OBJ_NEW_SMALL_INT(-value); case MP_UNARY_OP_INVERT: return MP_OBJ_NEW_SMALL_INT(~value); - - // only bool needs to implement MP_UNARY_OP_NOT - case MP_UNARY_OP_NOT: - if (value) { - return mp_const_false; - } else { - return mp_const_true; - } - default: return MP_OBJ_NULL; // op not supported } } |