summaryrefslogtreecommitdiffstatshomepage
path: root/extmod/vfs_fat_file.c
diff options
context:
space:
mode:
authorJim Mussared <jim.mussared@gmail.com>2022-09-16 23:57:38 +1000
committerDamien George <damien@micropython.org>2022-09-19 19:06:13 +1000
commit6da41b59007c9e9a2443ae17278d32210034a63f (patch)
tree7acd771be49b744b64571426c3e4c185abf31175 /extmod/vfs_fat_file.c
parent3c6127dfcfc63a2b48c31f751d1ae2c385874c8a (diff)
downloadmicropython-6da41b59007c9e9a2443ae17278d32210034a63f.tar.gz
micropython-6da41b59007c9e9a2443ae17278d32210034a63f.zip
py/obj: Merge getiter and iternext mp_obj_type_t slots.
The goal here is to remove a slot (making way to turn make_new into a slot) as well as reduce code size by the ~40 references to mp_identity_getiter and mp_stream_unbuffered_iter. This introduces two new type flags: - MP_TYPE_FLAG_ITER_IS_ITERNEXT: This means that the "iter" slot in the type is "iternext", and should use the identity getiter. - MP_TYPE_FLAG_ITER_IS_CUSTOM: This means that the "iter" slot is a pointer to a mp_getiter_iternext_custom_t instance, which then defines both getiter and iternext. And a third flag that is the OR of both, MP_TYPE_FLAG_ITER_IS_STREAM: This means that the type should use the identity getiter, and mp_stream_unbuffered_iter as iternext. Finally, MP_TYPE_FLAG_ITER_IS_GETITER is defined as a no-op flag to give the default case where "iter" is "getiter". Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
Diffstat (limited to 'extmod/vfs_fat_file.c')
-rw-r--r--extmod/vfs_fat_file.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/extmod/vfs_fat_file.c b/extmod/vfs_fat_file.c
index 00980459db..ca2e2b446f 100644
--- a/extmod/vfs_fat_file.c
+++ b/extmod/vfs_fat_file.c
@@ -179,11 +179,9 @@ STATIC const mp_stream_p_t vfs_fat_fileio_stream_p = {
MP_DEFINE_CONST_OBJ_TYPE(
mp_type_vfs_fat_fileio,
MP_QSTR_FileIO,
- MP_TYPE_FLAG_NONE,
+ MP_TYPE_FLAG_ITER_IS_STREAM,
MP_TYPE_NULL_MAKE_NEW,
print, file_obj_print,
- getiter, mp_identity_getiter,
- iternext, mp_stream_unbuffered_iter,
protocol, &vfs_fat_fileio_stream_p,
locals_dict, &vfs_fat_rawfile_locals_dict
);
@@ -198,11 +196,9 @@ STATIC const mp_stream_p_t vfs_fat_textio_stream_p = {
MP_DEFINE_CONST_OBJ_TYPE(
mp_type_vfs_fat_textio,
MP_QSTR_TextIOWrapper,
- MP_TYPE_FLAG_NONE,
+ MP_TYPE_FLAG_ITER_IS_STREAM,
MP_TYPE_NULL_MAKE_NEW,
print, file_obj_print,
- getiter, mp_identity_getiter,
- iternext, mp_stream_unbuffered_iter,
protocol, &vfs_fat_textio_stream_p,
locals_dict, &vfs_fat_rawfile_locals_dict
);