diff options
| author | iabdalkader <i.abdalkader@gmail.com> | 2023-03-26 19:50:39 +0200 |
|---|---|---|
| committer | Damien George <damien@micropython.org> | 2023-04-04 15:16:44 +1000 |
| commit | 9025671e7216d9fd73526a681568f78a330a6414 (patch) | |
| tree | 8ccd496efde37dc788147432aea2ade1cec4889c /drivers | |
| parent | 5652f1f661479f23468c90c531927f5f0a727979 (diff) | |
| download | micropython-9025671e7216d9fd73526a681568f78a330a6414.tar.gz micropython-9025671e7216d9fd73526a681568f78a330a6414.zip | |
drivers/ninaw10: Fix ESP32 input-only pins.
ESP32 pins 34, 35, 36 and 39 are input only, and should not be configured
as output.
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ninaw10/machine_pin_nina.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/ninaw10/machine_pin_nina.c b/drivers/ninaw10/machine_pin_nina.c index 3d98af0ef7..025ecb66af 100644 --- a/drivers/ninaw10/machine_pin_nina.c +++ b/drivers/ninaw10/machine_pin_nina.c @@ -43,6 +43,7 @@ #define NINA_GPIO_MODE (0x50) #define NINA_GPIO_READ (0x53) #define NINA_GPIO_WRITE (0x51) +#define NINA_GPIO_IS_INPUT_ONLY(p) ((p >= 34 && p <= 36) || (p == 39)) static uint8_t pin_map[MICROPY_HW_PIN_EXT_COUNT] = { 27, // LEDR @@ -82,12 +83,17 @@ void machine_pin_ext_config(machine_pin_obj_t *self, int mode, int value) { } else if (mode == MACHINE_PIN_MODE_OUT) { mode = NINA_GPIO_OUTPUT; self->is_output = true; - machine_pin_ext_set(self, value); } else { mp_raise_ValueError("only Pin.OUT and Pin.IN are supported for this pin"); } if (self->id >= 0 && self->id < MICROPY_HW_PIN_EXT_COUNT) { uint8_t buf[] = {pin_map[self->id], mode}; + if (mode == NINA_GPIO_OUTPUT) { + if (NINA_GPIO_IS_INPUT_ONLY(buf[0])) { + mp_raise_ValueError("only Pin.IN is supported for this pin"); + } + machine_pin_ext_set(self, value); + } nina_ioctl(NINA_GPIO_MODE, sizeof(buf), buf, 0); } } |