diff options
| author | 1cg <469183+1cg@users.noreply.github.com> | 2021-09-29 07:52:52 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-29 07:52:52 -0600 |
| commit | 202394c4d4d4b97dbf4162bf5922dac70028f6da (patch) | |
| tree | f85c0e9b0c79b618cd3c4b70a75b95113a4cfd33 | |
| parent | 5e0c740f75fede447ca545c8fc6cba08fa04ac0c (diff) | |
| parent | 443c271d4035467a39c91701df0e29f67e09a339 (diff) | |
| download | htmx-202394c4d4d4b97dbf4162bf5922dac70028f6da.tar.gz htmx-202394c4d4d4b97dbf4162bf5922dac70028f6da.zip | |
Merge pull request #602 from MamesPalmero/intersect-event-bug
Fix root: option of the intersect event
| -rw-r--r-- | src/htmx.js | 2 | ||||
| -rw-r--r-- | test/manual/intersect-test-eventHandler.html | 18 |
2 files changed, 19 insertions, 1 deletions
diff --git a/src/htmx.js b/src/htmx.js index 8ded9233..a1adc2c5 100644 --- a/src/htmx.js +++ b/src/htmx.js @@ -1361,7 +1361,7 @@ return (function () { } else if (triggerSpec.trigger === "intersect") { var observerOptions = {}; if (triggerSpec.root) { - observerOptions.root = querySelectorExt(triggerSpec.root) + observerOptions.root = querySelectorExt(elt, triggerSpec.root) } if (triggerSpec.threshold) { observerOptions.threshold = parseFloat(triggerSpec.threshold); diff --git a/test/manual/intersect-test-eventHandler.html b/test/manual/intersect-test-eventHandler.html index de99eb2d..7156b0cc 100644 --- a/test/manual/intersect-test-eventHandler.html +++ b/test/manual/intersect-test-eventHandler.html @@ -19,6 +19,12 @@ margin-bottom:20px; padding:20px; } + .container { + height:200px; + padding:20px; + border:1px solid black; + overflow:auto; + } </style> </head> @@ -36,6 +42,18 @@ <div class="panel" hx-get="/more_content" hx-trigger="intersect"></div> <div class="panel" hx-get="/more_content" hx-trigger="intersect"></div> +<h1>Root</h1> + +<div class="container" id="wrapper"> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +<div class="panel" hx-get="/more_content" hx-trigger="intersect root:#wrapper"></div> +</div> + <h1>Threshold .5</h1> <div class="panel" hx-get="/more_content" hx-trigger="intersect threshold:.5"></div> |