| Commit message (Collapse) | Author | Age |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This makes more use of $INPUT to access $_SERVER and fixes a warning in
one of the search methods.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code used to cache the result of resize and crop image
operations indefinitely. They only time these caches were refreshed were
when the original source changed.
This meant that changes in configuration (eg. the image quality setting)
were never applied to existing images, neither were changes/improvements
in the resizing code.
This patch introduces a new Cache class for these kind of modification
results.
It also removes more duplicated code in media_resize_image and
media_crop_image. Future refactorings may move this code into
File\MediaFile
This code should also fix currently weird results for plugin and
screenshot in the extension manager - TBH I am not 100% sure what
happened there but refreshing the cache once seems to solve the problem.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
In 2019 PSR-12 was officially released and PSR-2 deprecated. We should
adapt to that and check our files against that new coding standard.
|
|
|
|
| |
mostly overlong lines and more exclude patterns
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of writing our own magic getters and setters for all variables
that used to be public, this adds a trait that does that in a generic
way.
This trait was copied from MediaWiki and adjusted to DokuWiki.
The original author seems to be @tgr Tisza Gergő
The downside of this trait is that the properties keep their
(potentially undesired) name. While that could be fixed within the
helper, that might add unnecessary complexity. The name can change when
support is dropped.
|
|
|
|
|
| |
DokuWiki has its own way to report deprecation notifications.
Let's use it!
|
|
|
|
|
|
| |
These fields might still be accessed from the outside, so in order to
not break backwards compatibility, this uses magic methods that emit
deprecation errors.
|
|
|
|
|
|
| |
That method cannot be private or protected, since it has to be used by
the event handler. Thus adjust the method comment to internal to better
represent that it shouldn't be used by other classes.
|
| |
|
|
|
|
|
|
|
| |
The method _useCache doesn't seem to be in use outside the core cache
classes[0], thus no deprecation placeholder was created.
[0]: https://codesearch.dokuwiki.org/search?project=dokuwiki&project=plugin&project=template&q=&defs=&refs=_useCache&path=&hist=&type=php
|
|
|