From 93fc3d34f9285d337c1e19e84764b02629eaab68 Mon Sep 17 00:00:00 2001 From: Barney Gale Date: Mon, 10 Mar 2025 17:50:48 +0000 Subject: GH-127381: pathlib ABCs: remove `case_sensitive` argument (#131024) Remove the *case_sensitive* argument from `_JoinablePath.full_match()` and `_ReadablePath.glob()`. Using a non-native case sensitivity forces the use of "case-pedantic" globbing, where we `iterdir()` even for non-wildcard pattern segments. But it's hard to know when to enable this mode, as case-sensitivity can vary by directory, so `_PathParser.normcase()` doesn't always give the full picture. The `Path.glob()` implementation is forced to make an educated guess, but we can avoid the issue in the ABCs by dropping the *case_sensitive* argument. (I probably shouldn't have added these arguments in `PurePath` and `Path` in the first place!) Also drop support for `_ReadablePath.glob(recurse_symlinks=False)`, which makes recursive globbing much slower. --- Lib/test/test_pathlib/test_join.py | 5 ----- 1 file changed, 5 deletions(-) (limited to 'Lib/test/test_pathlib/test_join.py') diff --git a/Lib/test/test_pathlib/test_join.py b/Lib/test/test_pathlib/test_join.py index 93fd1e6488c..03a3ecfd248 100644 --- a/Lib/test/test_pathlib/test_join.py +++ b/Lib/test/test_pathlib/test_join.py @@ -130,11 +130,6 @@ class JoinTestBase: self.assertFalse(P('a/b/c.py').full_match('**/a/b/c./**')) self.assertFalse(P('a/b/c.py').full_match('/a/b/c.py/**')) self.assertFalse(P('a/b/c.py').full_match('/**/a/b/c.py')) - # Case-sensitive flag - self.assertFalse(P('A.py').full_match('a.PY', case_sensitive=True)) - self.assertTrue(P('A.py').full_match('a.PY', case_sensitive=False)) - self.assertFalse(P('c:/a/B.Py').full_match('C:/A/*.pY', case_sensitive=True)) - self.assertTrue(P('/a/b/c.py').full_match('/A/*/*.Py', case_sensitive=False)) # Matching against empty path self.assertFalse(P('').full_match('*')) self.assertTrue(P('').full_match('**')) -- cgit v1.2.3