From b8f4163da30e16c7cd58fe04f4b17e38d53cd57e Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 13 Sep 2017 01:47:22 -0700 Subject: bpo-31233: socketserver.ThreadingMixIn.server_close() (#3523) socketserver.ThreadingMixIn now keeps a list of non-daemonic threads to wait until all these threads complete in server_close(). Reenable test_logging skipped tests. Fix SocketHandlerTest.tearDown(): close the socket handler before stopping the server, so the server can join threads. --- Lib/socketserver.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'Lib/socketserver.py') diff --git a/Lib/socketserver.py b/Lib/socketserver.py index 721eb50fbe6..1ae7bef9040 100644 --- a/Lib/socketserver.py +++ b/Lib/socketserver.py @@ -629,6 +629,9 @@ class ThreadingMixIn: # Decides how threads will act upon termination of the # main process daemon_threads = False + # For non-daemonic threads, list of threading.Threading objects + # used by server_close() to wait for all threads completion. + _threads = None def process_request_thread(self, request, client_address): """Same as in BaseServer but as a thread. @@ -648,8 +651,20 @@ class ThreadingMixIn: t = threading.Thread(target = self.process_request_thread, args = (request, client_address)) t.daemon = self.daemon_threads + if not t.daemon: + if self._threads is None: + self._threads = [] + self._threads.append(t) t.start() + def server_close(self): + super().server_close() + threads = self._threads + self._threads = None + if threads: + for thread in threads: + thread.join() + if hasattr(os, "fork"): class ForkingUDPServer(ForkingMixIn, UDPServer): pass -- cgit v1.2.3